test: re-implement promises.setInterval() test robustly

Trott · danielleadams · commit 1fc830713851 · 2021-02-16T09:16:09.000-05:00
Fixes: #37226 PR-URL: #37230 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/parallel/test-timers-promisified.js b/test/parallel/test-timers-promisified.js
@@ -348,6 +348,34 @@ process.on('multipleResolves', common.mustNotCall());
 assert.strictEqual(loopCount, 5);
 }));
 }
+
+ {
+ // Check that if we abort when we have some unresolved callbacks,
+ // we actually call them.
+ const controller = new AbortController();
+ const { signal } = controller;
+ const delay = 10;
+ let totalIterations = 0;
+ const timeoutLoop = runInterval(async (iterationNumber) => {
+ await setTimeout(delay * 4);
+ if (iterationNumber <= 2) {
+ assert.strictEqual(signal.aborted, false);
+ }
+ if (iterationNumber === 2) {
+ controller.abort();
+ }
+ if (iterationNumber > 2) {
+ assert.strictEqual(signal.aborted, true);
+ }
+ if (iterationNumber > totalIterations) {
+ totalIterations = iterationNumber;
+ }
+ }, delay, signal);
+
+ timeoutLoop.catch(common.mustCall(() => {
+ assert.ok(totalIterations >= 3, `iterations was ${totalIterations} < 3`);
+ }));
+ }
 }
 
 {

-Original file line number
+Diff line change
 assert.strictEqual(loopCount,5);
 }));
+}
++
 +{
 +// Check that if we abort when we have some unresolved callbacks,
 +// we actually call them.
 +constcontroller=newAbortController();
 +const{ signal }=controller;
 +constdelay=10;
 +lettotalIterations=0;
 +consttimeoutLoop=runInterval(async(iterationNumber)=>{
 +awaitsetTimeout(delay*4);
 +if(iterationNumber<=2){
 +assert.strictEqual(signal.aborted,false);
 +}
 +if(iterationNumber===2){
 +controller.abort();
 +}
 +if(iterationNumber>2){
 +assert.strictEqual(signal.aborted,true);
 +}
 +if(iterationNumber>totalIterations){
 +totalIterations=iterationNumber;
 +}
 +},delay,signal);
++
 +timeoutLoop.catch(common.mustCall(()=>{
 +assert.ok(totalIterations>=3,`iterations was ${totalIterations} < 3`);
 +}));
 +}
+}
+{