child_process: remove unsafe array iteration

hotpineapple · richardlau · commit 208bc810a13e · 2025-09-20T03:33:57.000Z
PR-URL: #59347 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -639,7 +639,8 @@ function normalizeSpawnArguments(file, args, options) {
 
 if (options.shell) {
 validateArgumentNullCheck(options.shell, 'options.shell');
- const command = ArrayPrototypeJoin([file, ...args], ' ');
+
+ const command = args.length > 0 ? `${file} ${ArrayPrototypeJoin(args, ' ')}` : file;
 // Set the shell, switches, and commands.
 if (process.platform === 'win32') {
 if (typeof options.shell === 'string')

-Original file line number
+Diff line change
 if(options.shell){
 validateArgumentNullCheck(options.shell,'options.shell');
 -constcommand=ArrayPrototypeJoin([file, ...args],' ');
++
 +constcommand=args.length>0 ? `${file}${ArrayPrototypeJoin(args,' ')}` : file;
 // Set the shell, switches, and commands.
 if(process.platform==='win32'){
 if(typeofoptions.shell==='string')