test: use common/child_process spawnSync helpers

Replace manual spawnSync() result assertions
with test/common/child_process helper functions.
Signed-off-by: Junsoo Ha <junsoo2018@naver.com>
PR-URL: #65377
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: ganjanggejang

test/parallel/test-crypto-key-store-pkcs11.js

@@ -34,6 +34,7 @@ const {
  verify,
 }=require('crypto');
 consttmpdir=require('../common/tmpdir');
+const{ spawnSyncAndExitWithoutError }=require('../common/child_process');
 
 const{ subtle }=globalThis.crypto;
 constkData=Buffer.from(
@@ -65,15 +66,14 @@ function softhsmOptions() {
 
 functionrunInChild(){
 const{ cwd, env }=softhsmOptions();
-constchild=spawnSync(process.execPath,[
+spawnSyncAndExitWithoutError(process.execPath,[
 `--openssl-config=${kOpenSSLConfig}`,
 __filename,
 ],{
  cwd,
 env: { ...process.env, ...env,NODE_TEST_PKCS11_CHILD: '1'},
 stdio: 'inherit',
 });
-assert.strictEqual(child.status,0);
 }
 
 functionprivateKeyUrl(label){

test/parallel/test-experimental-shared-value-conveyor.js

@@ -1,8 +1,8 @@
 'use strict';
 constcommon=require('../common');
 constassert=require('assert');
-const{ spawnSync }=require('child_process');
 const{ Worker, parentPort }=require('worker_threads');
+const{ spawnSyncAndAssert }=require('../common/child_process');
 
 if(process.env.TEST_CHILD_PROCESS==='1'){
 // Do not use isMainThread so that this test itself can be run inside a Worker.
@@ -29,10 +29,10 @@ if (process.env.TEST_CHILD_PROCESS === '1') {
 
 constargs=['--harmony-struct',__filename];
 constoptions={env: {TEST_CHILD_PROCESS: '1', ...process.env}};
-constchild=spawnSync(process.execPath,args,options);
 
-assert.strictEqual(child.stderr.toString().trim(),'');
-assert.strictEqual(child.stdout.toString().trim(),'');
-assert.strictEqual(child.status,0);
-assert.strictEqual(child.signal,null);
+spawnSyncAndAssert(process.execPath,args,options,{
+stdout: '',
+stderr: '',
+trim: true
+});
 }

test/parallel/test-heap-prof-basic.js

@@ -9,7 +9,7 @@ const fixtures = require('../common/fixtures');
 common.skipIfInspectorDisabled();
 
 constassert=require('assert');
-const{spawnSync}=require('child_process');
+const{spawnSyncAndExitWithoutError}=require('../common/child_process');
 
 consttmpdir=require('../common/tmpdir');
 
@@ -20,18 +20,13 @@ const {
 
 {
 tmpdir.refresh();
-constoutput=spawnSync(process.execPath,[
+spawnSyncAndExitWithoutError(process.execPath,[
 '--heap-prof',
 fixtures.path('workload','allocation.js'),
 ],{
 cwd: tmpdir.path,
  env
 });
-if(output.status!==0){
-console.log(output.stderr.toString());
-console.log(output);
-}
-assert.strictEqual(output.status,0);
 constprofiles=getHeapProfiles(tmpdir.path);
 assert.strictEqual(profiles.length,1);
 }

test/parallel/test-heap-prof-exec-argv.js

@@ -9,7 +9,7 @@ const fixtures = require('../common/fixtures');
 common.skipIfInspectorDisabled();
 
 constassert=require('assert');
-const{spawnSync}=require('child_process');
+const{spawnSyncAndExitWithoutError}=require('../common/child_process');
 
 consttmpdir=require('../common/tmpdir');
 
@@ -20,7 +20,7 @@ const {
 
 {
 tmpdir.refresh();
-constoutput=spawnSync(process.execPath,[
+const{child: output}=spawnSyncAndExitWithoutError(process.execPath,[
 fixtures.path('workload','allocation-worker-argv.js'),
 ],{
 cwd: tmpdir.path,
@@ -29,10 +29,6 @@ const {
 HEAP_PROF_INTERVAL: '128'
 }
 });
-if(output.status!==0){
-console.log(output.stderr.toString());
-}
-assert.strictEqual(output.status,0);
 constprofiles=getHeapProfiles(tmpdir.path);
 assert.strictEqual(profiles.length,1);
 verifyFrames(output,profiles[0],'runAllocation');

test/parallel/test-heap-prof-loop-drained.js

@@ -8,7 +8,7 @@ const fixtures = require('../common/fixtures');
 common.skipIfInspectorDisabled();
 
 constassert=require('assert');
-const{spawnSync}=require('child_process');
+const{spawnSyncAndExitWithoutError}=require('../common/child_process');
 
 consttmpdir=require('../common/tmpdir');
 
@@ -21,7 +21,7 @@ const {
 
 {
 tmpdir.refresh();
-constoutput=spawnSync(process.execPath,[
+const{child: output}=spawnSyncAndExitWithoutError(process.execPath,[
 '--heap-prof',
 '--heap-prof-interval',
 kHeapProfInterval,
@@ -30,11 +30,6 @@ const {
 cwd: tmpdir.path,
  env
 });
-if(output.status!==0){
-console.log(output.stderr.toString());
-console.log(output);
-}
-assert.strictEqual(output.status,0);
 constprofiles=getHeapProfiles(tmpdir.path);
 assert.strictEqual(profiles.length,1);
 verifyFrames(output,profiles[0],'runAllocation');

test/parallel/test-inspect-address-in-use.js

@@ -2,7 +2,7 @@
 constcommon=require('../common');
 common.skipIfInspectorDisabled();
 
-const{spawnSync}=require('child_process');
+const{spawnSyncAndExit}=require('../common/child_process');
 const{ createServer }=require('http');
 constassert=require('assert');
 consttmpdir=require('../common/tmpdir');
@@ -25,19 +25,18 @@ function testOnServerListen(fn) {
 functiontestChildProcess(getArgs,exitCode,options){
 testOnServerListen(common.mustCall((server)=>{
 const{ port }=server.address();
-constchild=spawnSync(process.execPath,getArgs(port),options);
-conststderr=child.stderr.toString().trim();
-conststdout=child.stdout.toString().trim();
-console.log('[STDERR]');
-console.log(stderr);
-console.log('[STDOUT]');
-console.log(stdout);
-constmatch=stderr.match(
-/Startinginspectoron127\.0\.0\.1:(\d+)failed:addressalreadyinuse/
-);
-assert.notStrictEqual(match,null);
-assert.strictEqual(match[1],port+'');
-assert.strictEqual(child.status,exitCode);
+spawnSyncAndExit(process.execPath,getArgs(port),options,{
+status: exitCode,
+signal: null,
+trim: true,
+stderr: function(str){
+constmatch=str.match(
+/Startinginspectoron127\.0\.0\.1:(\d+)failed:addressalreadyinuse/
+);
+assert.notStrictEqual(match,null);
+assert.strictEqual(match[1],port+'');
+},
+});
 }));
 }
 

test/parallel/test-os-homedir-no-envvar.js

@@ -1,9 +1,9 @@
 'use strict';
 constcommon=require('../common');
 constassert=require('assert');
-constcp=require('child_process');
 constos=require('os');
 constpath=require('path');
+const{ spawnSyncAndExitWithoutError }=require('../common/child_process');
 
 
 if(process.argv[2]==='child'){
@@ -22,9 +22,7 @@ if (process.argv[2] === 'child') {
 else
 deleteprocess.env.HOME;
 
-constchild=cp.spawnSync(process.execPath,[__filename,'child'],{
+spawnSyncAndExitWithoutError(process.execPath,[__filename,'child'],{
 env: process.env
 });
-
-assert.strictEqual(child.status,0);
 }

test/parallel/test-process-execpath.js

@@ -4,7 +4,7 @@ if (common.isWindows)
 common.skip('symlinks are weird on windows');
 
 constassert=require('assert');
-constchild_process=require('child_process');
+const{ spawnSyncAndAssert }=require('../common/child_process');
 constfs=require('fs');
 
 assert.strictEqual(process.execPath,fs.realpathSync(process.execPath));
@@ -19,8 +19,8 @@ if (process.argv[2] === 'child') {
 constsymlinkedNode=tmpdir.resolve('symlinked-node');
 fs.symlinkSync(process.execPath,symlinkedNode);
 
-constproc=child_process.spawnSync(symlinkedNode,[__filename,'child']);
-assert.strictEqual(proc.stderr.toString(),'');
-assert.strictEqual(proc.stdout.toString(),`${process.execPath}\n`);
-assert.strictEqual(proc.status,0);
+spawnSyncAndAssert(symlinkedNode,[__filename,'child'],{
+stdout: `${process.execPath}\n`,
+stderr: ''
+});
 }

test/parallel/test-runner-mock-timers-with-timeout.js

@@ -1,14 +1,12 @@
 'use strict';
 require('../common');
 constfixtures=require('../common/fixtures');
-constassert=require('node:assert');
-const{ spawnSync }=require('node:child_process');
+const{ spawnSyncAndExitWithoutError }=require('../common/child_process');
 const{ test }=require('node:test');
 
 test('mock timers do not break test timeout cleanup',async()=>{
 constfixture=fixtures.path('test-runner','mock-timers-with-timeout.js');
-constcp=spawnSync(process.execPath,['--test',fixture],{
+spawnSyncAndExitWithoutError(process.execPath,['--test',fixture],{
 timeout: 30_000,
 });
-assert.strictEqual(cp.status,0,`Test failed:\nstdout: ${cp.stdout}\nstderr: ${cp.stderr}`);
 });

test/parallel/test-v8-stop-coverage.js

@@ -5,15 +5,15 @@ const fixtures = require('../common/fixtures');
 consttmpdir=require('../common/tmpdir');
 constassert=require('assert');
 constfs=require('fs');
-const{spawnSync}=require('child_process');
+const{spawnSyncAndExitWithoutError}=require('../common/child_process');
 
 common.skipIfInspectorDisabled();
 
 tmpdir.refresh();
 constintervals=20;
 
 {
-constoutput=spawnSync(process.execPath,[
+const{ child }=spawnSyncAndExitWithoutError(process.execPath,[
 '-r',
 fixtures.path('v8-coverage','stop-coverage'),
 '-r',
@@ -27,8 +27,7 @@ const intervals = 20;
 TEST_INTERVALS: intervals
 },
 });
-console.log(output.stderr.toString());
-assert.strictEqual(output.status,0);
+console.log(child.stderr.toString());
 constcoverageFiles=fs.readdirSync(tmpdir.path);
 assert.strictEqual(coverageFiles.length,0);
 }