esm: remove unnecessary toNamespacedPath calls

anonrig · aduh95 · commit 262f2cb3b68c · 2024-07-16T12:01:09.000+02:00
PR-URL: #53656 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/modules/esm/resolve.js b/lib/internal/modules/esm/resolve.js
@@ -27,7 +27,7 @@ const { BuiltinModule } = require('internal/bootstrap/realm');
 const { realpathSync } = require('fs');
 const { getOptionValue } = require('internal/options');
 // Do not eagerly grab .manifest, it may be in TDZ
-const { sep, posix: { relative: relativePosixPath }, toNamespacedPath, resolve } = require('path');
+const { sep, posix: { relative: relativePosixPath }, resolve } = require('path');
 const preserveSymlinks = getOptionValue('--preserve-symlinks');
 const preserveSymlinksMain = getOptionValue('--preserve-symlinks-main');
 const experimentalNetworkImports =
@@ -246,8 +246,8 @@ function finalizeResolution(resolved, base, preserveSymlinks) {
 throw err;
 }
 
- const stats = internalFsBinding.internalModuleStat(toNamespacedPath(StringPrototypeEndsWith(path, '/') ?
- StringPrototypeSlice(path, -1) : path));
+ const stats = internalFsBinding.internalModuleStat(StringPrototypeEndsWith(path, '/') ?
+ StringPrototypeSlice(path, -1) : path);
 
 // Check for stats.isDirectory()
 if (stats === 1) {
@@ -807,7 +807,7 @@ function packageResolve(specifier, base, conditions) {
 let lastPath;
 do {
 const stat = internalFsBinding.internalModuleStat(
- toNamespacedPath(StringPrototypeSlice(packageJSONPath, 0, packageJSONPath.length - 13)),
+ StringPrototypeSlice(packageJSONPath, 0, packageJSONPath.length - 13),
 );
 // Check for !stat.isDirectory()
 if (stat !== 1) {

-Original file line number
+Diff line change
 const{ realpathSync }=require('fs');
 const{ getOptionValue }=require('internal/options');
 // Do not eagerly grab .manifest, it may be in TDZ
 -const{ sep,posix: {relative: relativePosixPath},toNamespacedPath,resolve }=require('path');
 +const{ sep,posix: {relative: relativePosixPath}, resolve }=require('path');
 constpreserveSymlinks=getOptionValue('--preserve-symlinks');
 constpreserveSymlinksMain=getOptionValue('--preserve-symlinks-main');
 constexperimentalNetworkImports=
 throwerr;
+}
 -conststats=internalFsBinding.internalModuleStat(toNamespacedPath(StringPrototypeEndsWith(path,'/') ?
 -StringPrototypeSlice(path,-1) : path));
 +conststats=internalFsBinding.internalModuleStat(StringPrototypeEndsWith(path,'/') ?
 +StringPrototypeSlice(path,-1) : path);
 // Check for stats.isDirectory()
 if(stats===1){
 letlastPath;
 do{
 conststat=internalFsBinding.internalModuleStat(
 -toNamespacedPath(StringPrototypeSlice(packageJSONPath,0,packageJSONPath.length-13)),
 +StringPrototypeSlice(packageJSONPath,0,packageJSONPath.length-13),
 );
 // Check for !stat.isDirectory()
 if(stat!==1){