console: improve inspectOptions validation

This commit adds stricter type checking to the inspectOptions
option to the Console constructor.
PR-URL: #25090
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: cjihrig

lib/internal/console/constructor.js

@@ -91,13 +91,15 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
 if(typeofcolorMode!=='boolean'&&colorMode!=='auto')
 thrownewERR_INVALID_ARG_VALUE('colorMode',colorMode);
 
-if(inspectOptions){
+if(typeofinspectOptions==='object'&&inspectOptions!==null){
 if(inspectOptions.colors!==undefined&&
 options.colorMode!==undefined){
 thrownewERR_INCOMPATIBLE_OPTION_PAIR(
 'inspectOptions.color','colorMode');
 }
 optionsMap.set(this,inspectOptions);
+}elseif(inspectOptions!==undefined){
+thrownewERR_INVALID_ARG_TYPE('inspectOptions','object',inspectOptions);
 }
 
 // Bind the prototype functions to this Console instance

test/parallel/test-console-instance.js

@@ -128,3 +128,21 @@ out.write = err.write = (d) => {};
 assert.throws(()=>c2.warn('foo'),/^Error:err$/);
 assert.throws(()=>c2.dir('foo'),/^Error:out$/);
 }
+
+// Console constructor throws if inspectOptions is not an object.
+[null,true,false,'foo',5,Symbol()].forEach((inspectOptions)=>{
+assert.throws(
+()=>{
+newConsole({
+stdout: out,
+stderr: err,
+ inspectOptions
+});
+},
+{
+message: 'The "inspectOptions" argument must be of type object.'+
+` Received type ${typeofinspectOptions}`,
+code: 'ERR_INVALID_ARG_TYPE'
+}
+);
+});