test: remove unused function arguments in async-hooks tests

Remove unused function arguments in three async-hooks tests and
improve test consistancy.
PR-URL: #24406
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: blacksun1

test/async-hooks/test-promise.chain-promise-before-init-hooks.js

@@ -8,11 +8,11 @@ const { checkInvocations } = require('./hook-checks');
 if(!common.isMainThread)
 common.skip('Worker bootstrapping works differently -> different async IDs');
 
-constp=newPromise(common.mustCall(functionexecutor(resolve,reject){
+constp=newPromise(common.mustCall(functionexecutor(resolve){
 resolve(5);
 }));
 
-p.then(functionafterresolution(val){
+p.then(functionafterResolution(val){
 assert.strictEqual(val,5);
 returnval;
 });

test/async-hooks/test-promise.js

@@ -13,24 +13,22 @@ const hooks = initHooks();
 
 hooks.enable();
 
-constp=(newPromise(common.mustCall(executor)));
-p.then(afterresolution);
-
-functionexecutor(resolve,reject){
-constas=hooks.activitiesOfTypes('PROMISE');
-assert.strictEqual(as.length,1);
-consta=as[0];
-checkInvocations(a,{init: 1},'while in promise executor');
-resolve(5);
-}
-
-functionafterresolution(val){
+constp=newPromise(common.mustCall(executor));
+p.then(functionafterResolution(val){
 assert.strictEqual(val,5);
 constas=hooks.activitiesOfTypes('PROMISE');
 assert.strictEqual(as.length,2);
 checkInvocations(as[0],{init: 1},'after resolution parent promise');
 checkInvocations(as[1],{init: 1,before: 1},
 'after resolution child promise');
+});
+
+functionexecutor(resolve){
+constas=hooks.activitiesOfTypes('PROMISE');
+assert.strictEqual(as.length,1);
+consta=as[0];
+checkInvocations(a,{init: 1},'while in promise executor');
+resolve(5);
 }
 
 process.on('exit',onexit);

test/async-hooks/test-promise.promise-before-init-hooks.js

@@ -5,15 +5,15 @@ const assert = require('assert');
 constinitHooks=require('./init-hooks');
 const{ checkInvocations }=require('./hook-checks');
 
-constp=newPromise(common.mustCall(functionexecutor(resolve,reject){
+constp=newPromise(common.mustCall(functionexecutor(resolve){
 resolve(5);
 }));
 
 // init hooks after promise was created
 consthooks=initHooks({allowNoInit: true});
 hooks.enable();
 
-p.then(functionafterresolution(val){
+p.then(functionafterResolution(val){
 assert.strictEqual(val,5);
 constas=hooks.activitiesOfTypes('PROMISE');
 assert.strictEqual(as.length,1);