permission: mark const functions as such

Otherwise, non-mutating functions such as is_tree_granted unnecessarily
require pointers to mutable data structures.
PR-URL: #50705
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

Author: tniessen

src/permission/child_process_permission.cc

@@ -15,7 +15,7 @@ void ChildProcessPermission::Apply(const std::vector<std::string>& allow,
 }
 
 boolChildProcessPermission::is_granted(PermissionScope perm,
-const std::string_view& param) {
+const std::string_view& param) const{
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -15,7 +15,7 @@ class ChildProcessPermission final : public PermissionBase {
 voidApply(const std::vector<std::string>& allow,
  PermissionScope scope) override;
 boolis_granted(PermissionScope perm,
-const std::string_view& param = "") override;
+const std::string_view& param = "") constoverride;
 
 private:
 bool deny_all_;

src/permission/fs_permission.cc

@@ -50,8 +50,9 @@ void FreeRecursivelyNode(
 delete node;
 }
 
-boolis_tree_granted(node::permission::FSPermission::RadixTree* granted_tree,
-const std::string_view& param) {
+boolis_tree_granted(
+const node::permission::FSPermission::RadixTree* granted_tree,
+const std::string_view& param) {
 #ifdef _WIN32
 // is UNC file path
 if (param.rfind("\\\\", 0) == 0) {
@@ -147,7 +148,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 }
 
 boolFSPermission::is_granted(PermissionScope perm,
-const std::string_view& param = "") {
+const std::string_view& param = "") const{
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -171,7 +172,7 @@ FSPermission::RadixTree::~RadixTree() {
 }
 
 boolFSPermission::RadixTree::Lookup(const std::string_view& s,
-bool when_empty_return = false) {
+bool when_empty_return = false) const{
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.size() == 0) {
 return when_empty_return;

src/permission/fs_permission.h

@@ -17,7 +17,8 @@ class FSPermission final : public PermissionBase {
 public:
 voidApply(const std::vector<std::string>& allow,
  PermissionScope scope) override;
-boolis_granted(PermissionScope perm, const std::string_view& param) override;
+boolis_granted(PermissionScope perm,
+const std::string_view& param) constoverride;
 
 structRadixTree {
 structNode {
@@ -72,7 +73,7 @@ class FSPermission final : public PermissionBase {
 return wildcard_child;
  }
 
- Node* NextNode(const std::string& path, size_t idx) {
+ Node* NextNode(const std::string& path, size_t idx) const{
 if (idx >= path.length()) {
 returnnullptr;
  }
@@ -115,7 +116,7 @@ class FSPermission final : public PermissionBase {
 // ---> '\000' ASCII (0) || \0
 // ---> er
 // ---> n
-boolIsEndNode() {
+boolIsEndNode() const{
 if (children.size() == 0) {
 returntrue;
  }
@@ -126,8 +127,8 @@ class FSPermission final : public PermissionBase {
 RadixTree();
 ~RadixTree();
 voidInsert(const std::string& s);
-boolLookup(const std::string_view& s) { returnLookup(s, false); }
-boolLookup(const std::string_view& s, bool when_empty_return);
+boolLookup(const std::string_view& s) const{ returnLookup(s, false); }
+boolLookup(const std::string_view& s, bool when_empty_return)const;
 
 private:
  Node* root_node_;

src/permission/inspector_permission.cc

@@ -14,7 +14,7 @@ void InspectorPermission::Apply(const std::vector<std::string>& allow,
 }
 
 boolInspectorPermission::is_granted(PermissionScope perm,
-const std::string_view& param) {
+const std::string_view& param) const{
 return deny_all_ == false;
 }
 

src/permission/inspector_permission.h

@@ -15,7 +15,7 @@ class InspectorPermission final : public PermissionBase {
 voidApply(const std::vector<std::string>& allow,
  PermissionScope scope) override;
 boolis_granted(PermissionScope perm,
-const std::string_view& param = "") override;
+const std::string_view& param = "") constoverride;
 
 private:
 bool deny_all_;

src/permission/permission_base.h

@@ -42,7 +42,7 @@ class PermissionBase {
 virtualvoidApply(const std::vector<std::string>& allow,
  PermissionScope scope) = 0;
 virtualboolis_granted(PermissionScope perm,
-const std::string_view& param = "") = 0;
+const std::string_view& param = "") const= 0;
 };
 
 } // namespace permission

src/permission/worker_permission.cc

@@ -15,7 +15,7 @@ void WorkerPermission::Apply(const std::vector<std::string>& allow,
 }
 
 boolWorkerPermission::is_granted(PermissionScope perm,
-const std::string_view& param) {
+const std::string_view& param) const{
 return deny_all_ == false;
 }
 

src/permission/worker_permission.h

@@ -15,7 +15,7 @@ class WorkerPermission final : public PermissionBase {
 voidApply(const std::vector<std::string>& allow,
  PermissionScope scope) override;
 boolis_granted(PermissionScope perm,
-const std::string_view& param = "") override;
+const std::string_view& param = "") constoverride;
 
 private:
 bool deny_all_;