events: variable originalListener is useless

fuxingZhang · codebytere · commit 27c90efce060 · 2020-06-18T09:46:09.000-07:00
PR-URL: #33596 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/events.js b/lib/events.js
@@ -449,8 +449,6 @@ EventEmitter.prototype.prependOnceListener =
 // Emits a 'removeListener' event if and only if the listener was removed.
 EventEmitter.prototype.removeListener =
 function removeListener(type, listener) {
- let originalListener;
-
 checkListener(listener);
 
 const events = this._events;
@@ -474,7 +472,6 @@ EventEmitter.prototype.removeListener =
 
 for (let i = list.length - 1; i >= 0; i--) {
 if (list[i] === listener || list[i].listener === listener) {
- originalListener = list[i].listener;
 position = i;
 break;
 }
@@ -495,7 +492,7 @@ EventEmitter.prototype.removeListener =
 events[type] = list[0];
 
 if (events.removeListener !== undefined)
- this.emit('removeListener', type, originalListener || listener);
+ this.emit('removeListener', type, listener);
 }
 
 return this;

-Original file line number
+Diff line change
 // Emits a 'removeListener' event if and only if the listener was removed.
 EventEmitter.prototype.removeListener=
 functionremoveListener(type,listener){
 -letoriginalListener;
+-
 checkListener(listener);
 constevents=this._events;
 for(leti=list.length-1;i>=0;i--){
 if(list[i]===listener||list[i].listener===listener){
 -originalListener=list[i].listener;
 position=i;
 break;
+}
 events[type]=list[0];
 if(events.removeListener!==undefined)
 -this.emit('removeListener',type,originalListener||listener);
 +this.emit('removeListener',type,listener);
+}
 returnthis;