test: add implicit test for fs dispose handling with using

IlyasShabi · aduh95 · commit 29399501c1f6 · 2026-01-22T14:46:33.000+01:00
PR-URL: #61140 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/parallel/test-fs-promises-file-handle-dispose.js b/test/parallel/test-fs-promises-file-handle-dispose.js
@@ -22,5 +22,29 @@ async function explicitCall() {
 assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
 }
 
+async function implicitCall() {
+ let fh;
+ {
+ await using openHandle = await fs.open(__filename);
+ fh = openHandle;
+ fh.on('close', common.mustCall());
+ }
+ assert.strictEqual(fh.fd, -1);
+
+ let dh;
+ {
+ await using dirHandle = await fs.opendir(__dirname);
+ dh = dirHandle;
+ }
+ await assert.rejects(dh.read(), { code: 'ERR_DIR_CLOSED' });
+
+ let dhSync;
+ {
+ using dirHandleSync = opendirSync(__dirname);
+ dhSync = dirHandleSync;
+ }
+ assert.throws(() => dhSync.readSync(), { code: 'ERR_DIR_CLOSED' });
+}
+
 explicitCall().then(common.mustCall());
-// TODO(aduh95): add test for implicit calls, with `await using` syntax.
+implicitCall().then(common.mustCall());

-Original file line number
+Diff line change
 assert.throws(()=>dhSync.readSync(),{code: 'ERR_DIR_CLOSED'});
+}
 +asyncfunctionimplicitCall(){
 +letfh;
 +{
 +awaitusingopenHandle=awaitfs.open(__filename);
 +fh=openHandle;
 +fh.on('close',common.mustCall());
 +}
 +assert.strictEqual(fh.fd,-1);
++
 +letdh;
 +{
 +awaitusingdirHandle=awaitfs.opendir(__dirname);
 +dh=dirHandle;
 +}
 +awaitassert.rejects(dh.read(),{code: 'ERR_DIR_CLOSED'});
++
 +letdhSync;
 +{
 +usingdirHandleSync=opendirSync(__dirname);
 +dhSync=dirHandleSync;
 +}
 +assert.throws(()=>dhSync.readSync(),{code: 'ERR_DIR_CLOSED'});
 +}
++
 explicitCall().then(common.mustCall());
 -// TODO(aduh95): add test for implicit calls, with `await using` syntax.
 +implicitCall().then(common.mustCall());