lib: prefer call() over apply() if argument list is not array

PR-URL: #60796
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: LiviaMedeiros

lib/assert.js

@@ -27,13 +27,13 @@ const {
  ArrayPrototypePush,
  ArrayPrototypeSlice,
  Error,
+ FunctionPrototypeCall,
  NumberIsNaN,
  ObjectAssign,
  ObjectDefineProperty,
  ObjectIs,
  ObjectKeys,
  ObjectPrototypeIsPrototypeOf,
- ReflectApply,
  RegExpPrototypeExec,
  String,
  StringPrototypeIndexOf,
@@ -550,7 +550,7 @@ function expectedException(actual, expected, message, fn) {
 throwError=true;
 }else{
 // Check validation functions return value.
-constres=ReflectApply(expected,{},[actual]);
+constres=FunctionPrototypeCall(expected,{},actual);
 if(res!==true){
 if(!message){
 generatedMessage=true;
@@ -695,7 +695,7 @@ function hasMatchingError(actual, expected) {
 if(ObjectPrototypeIsPrototypeOf(Error,expected)){
 returnfalse;
 }
-returnReflectApply(expected,{},[actual])===true;
+returnFunctionPrototypeCall(expected,{},actual)===true;
 }
 
 functionexpectsNoError(stackStartFn,actual,error,message){

lib/dgram.js

@@ -29,7 +29,6 @@ const {
  FunctionPrototypeCall,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
- ReflectApply,
  SymbolAsyncDispose,
  SymbolDispose,
 }=primordials;
@@ -436,7 +435,7 @@ Socket.prototype.connect = function(port, address, callback) {
 return;
 }
 
-ReflectApply(_connect,this,[port,address,callback]);
+FunctionPrototypeCall(_connect,this,port,address,callback);
 };
 
 

lib/fs.js

@@ -29,6 +29,7 @@ const {
  ArrayPrototypePush,
  BigIntPrototypeToString,
  Boolean,
+ FunctionPrototypeCall,
  MathMax,
  Number,
  ObjectDefineProperties,
@@ -365,7 +366,7 @@ function readFile(path, options, callback) {
 }
 if(context.isUserFd){
 process.nextTick(functiontick(context){
-ReflectApply(readFileAfterOpen,{ context },[null,path]);
+FunctionPrototypeCall(readFileAfterOpen,{ context },null,path);
 },context);
 return;
 }

lib/internal/child_process.js

@@ -805,8 +805,7 @@ function setupChannel(target, channel, serializationMode) {
 obj=handleConversion[message.type];
 
 // convert TCP object to native handle object
-handle=ReflectApply(handleConversion[message.type].send,
-target,[message,handle,options]);
+handle=FunctionPrototypeCall(handleConversion[message.type].send,target,message,handle,options);
 
 // If handle was sent twice, or it is impossible to get native handle
 // out of it - just send a text without the handle.

lib/internal/cluster/child.js

@@ -3,6 +3,7 @@
 const{
  ArrayPrototypeJoin,
  FunctionPrototype,
+ FunctionPrototypeCall,
  ObjectAssign,
  ReflectApply,
  SafeMap,
@@ -58,7 +59,7 @@ cluster._setupWorker = function() {
 if(message.act==='newconn')
 onconnection(message,handle);
 elseif(message.act==='disconnect')
-ReflectApply(_disconnect,worker,[true]);
+FunctionPrototypeCall(_disconnect,worker,true);
 }
 };
 
@@ -287,7 +288,7 @@ function _disconnect(primaryInitiated) {
 Worker.prototype.disconnect=function(){
 if(this.state!=='disconnecting'&&this.state!=='destroying'){
 this.state='disconnecting';
-ReflectApply(_disconnect,this,[]);
+FunctionPrototypeCall(_disconnect,this);
 }
 
 returnthis;

lib/internal/cluster/worker.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const{
+ FunctionPrototypeCall,
  ObjectSetPrototypeOf,
  ReflectApply,
 }=primordials;
@@ -16,7 +17,7 @@ function Worker(options) {
 if(!(thisinstanceofWorker))
 returnnewWorker(options);
 
-ReflectApply(EventEmitter,this,[]);
+FunctionPrototypeCall(EventEmitter,this);
 
 if(options===null||typeofoptions!=='object')
 options=kEmptyObject;

lib/internal/crypto/cipher.js

@@ -1,9 +1,9 @@
 'use strict';
 
 const{
+ FunctionPrototypeCall,
  NumberIsInteger,
  ObjectSetPrototypeOf,
- ReflectApply,
 }=primordials;
 
 const{
@@ -117,15 +117,15 @@ function createCipherBase(cipher, credential, options, isEncrypt, iv) {
 this[kHandle]=newCipherBase(isEncrypt,cipher,credential,iv,authTagLength);
 this._decoder=null;
 
-ReflectApply(LazyTransform,this,[options]);
+FunctionPrototypeCall(LazyTransform,this,options);
 }
 
 functioncreateCipherWithIV(cipher,key,options,isEncrypt,iv){
 validateString(cipher,'cipher');
 constencoding=getStringOption(options,'encoding');
 key=prepareSecretKey(key,encoding);
 iv=iv===null ? null : getArrayBufferOrView(iv,'iv');
-ReflectApply(createCipherBase,this,[cipher,key,options,isEncrypt,iv]);
+FunctionPrototypeCall(createCipherBase,this,cipher,key,options,isEncrypt,iv);
 }
 
 // The Cipher class is part of the legacy Node.js crypto API. It exposes
@@ -215,7 +215,7 @@ function Cipheriv(cipher, key, iv, options) {
 if(!(thisinstanceofCipheriv))
 returnnewCipheriv(cipher,key,iv,options);
 
-ReflectApply(createCipherWithIV,this,[cipher,key,options,true,iv]);
+FunctionPrototypeCall(createCipherWithIV,this,cipher,key,options,true,iv);
 }
 
 functionaddCipherPrototypeFunctions(constructor){
@@ -244,7 +244,7 @@ function Decipheriv(cipher, key, iv, options) {
 if(!(thisinstanceofDecipheriv))
 returnnewDecipheriv(cipher,key,iv,options);
 
-ReflectApply(createCipherWithIV,this,[cipher,key,options,false,iv]);
+FunctionPrototypeCall(createCipherWithIV,this,cipher,key,options,false,iv);
 }
 
 ObjectSetPrototypeOf(Decipheriv.prototype,LazyTransform.prototype);

lib/internal/crypto/hash.js

@@ -1,8 +1,8 @@
 'use strict';
 
 const{
+ FunctionPrototypeCall,
  ObjectSetPrototypeOf,
- ReflectApply,
  StringPrototypeReplace,
  StringPrototypeToLowerCase,
  Symbol,
@@ -105,7 +105,7 @@ function Hash(algorithm, options) {
 if(!isCopy&&xofLen===undefined){
 maybeEmitDeprecationWarning(algorithm);
 }
-ReflectApply(LazyTransform,this,[options]);
+FunctionPrototypeCall(LazyTransform,this,options);
 }
 
 ObjectSetPrototypeOf(Hash.prototype,LazyTransform.prototype);
@@ -169,7 +169,7 @@ function Hmac(hmac, key, options) {
 this[kState]={
 [kFinalized]: false,
 };
-ReflectApply(LazyTransform,this,[options]);
+FunctionPrototypeCall(LazyTransform,this,options);
 }
 
 ObjectSetPrototypeOf(Hmac.prototype,LazyTransform.prototype);

lib/internal/crypto/sig.js

@@ -3,7 +3,6 @@
 const{
  FunctionPrototypeCall,
  ObjectSetPrototypeOf,
- ReflectApply,
 }=primordials;
 
 const{
@@ -59,7 +58,7 @@ function Sign(algorithm, options) {
 this[kHandle]=new_Sign();
 this[kHandle].init(algorithm);
 
-ReflectApply(Writable,this,[options]);
+FunctionPrototypeCall(Writable,this,options);
 }
 
 ObjectSetPrototypeOf(Sign.prototype,Writable.prototype);
@@ -219,7 +218,7 @@ function Verify(algorithm, options) {
 this[kHandle]=new_Verify();
 this[kHandle].init(algorithm);
 
-ReflectApply(Writable,this,[options]);
+FunctionPrototypeCall(Writable,this,options);
 }
 
 ObjectSetPrototypeOf(Verify.prototype,Writable.prototype);

lib/internal/crypto/webcrypto.js

@@ -2,6 +2,7 @@
 
 const{
  ArrayPrototypeIncludes,
+ FunctionPrototypeCall,
  JSONParse,
  JSONStringify,
  ObjectDefineProperties,
@@ -84,7 +85,7 @@ async function digest(algorithm, data) {
 
 algorithm=normalizeAlgorithm(algorithm,'digest');
 
-returnawaitReflectApply(asyncDigest,this,[algorithm,data]);
+returnawaitFunctionPrototypeCall(asyncDigest,this,algorithm,data);
 }
 
 functionrandomUUID(){
@@ -377,10 +378,10 @@ async function deriveKey(
 throwlazyDOMException('Unrecognized algorithm name','NotSupportedError');
 }
 
-returnReflectApply(
+returnFunctionPrototypeCall(
 importKeySync,
 this,
-['raw-secret',bits,derivedKeyAlgorithm,extractable,keyUsages],
+'raw-secret',bits,derivedKeyAlgorithm,extractable,keyUsages,
 );
 }
 
@@ -889,10 +890,10 @@ async function importKey(
 
 algorithm=normalizeAlgorithm(algorithm,'importKey');
 
-returnReflectApply(
+returnFunctionPrototypeCall(
 importKeySync,
 this,
-[format,keyData,algorithm,extractable,keyUsages],
+format,keyData,algorithm,extractable,keyUsages,
 );
 }
 
@@ -926,7 +927,7 @@ async function wrapKey(format, key, wrappingKey, algorithm) {
 }catch{
 algorithm=normalizeAlgorithm(algorithm,'encrypt');
 }
-letkeyData=awaitReflectApply(exportKey,this,[format,key]);
+letkeyData=awaitFunctionPrototypeCall(exportKey,this,format,key);
 
 if(format==='jwk'){
 constec=newTextEncoder();
@@ -1023,10 +1024,10 @@ async function unwrapKey(
 }
 }
 
-returnReflectApply(
+returnFunctionPrototypeCall(
 importKeySync,
 this,
-[format,keyData,unwrappedKeyAlgo,extractable,keyUsages],
+format,keyData,unwrappedKeyAlgo,extractable,keyUsages,
 );
 }
 
@@ -1349,10 +1350,10 @@ async function encapsulateKey(encapsulationAlgorithm, encapsulationKey, sharedKe
 throwlazyDOMException('Unrecognized algorithm name','NotSupportedError');
 }
 
-constsharedKey=ReflectApply(
+constsharedKey=FunctionPrototypeCall(
 importKeySync,
 this,
-['raw-secret',encapsulateBits.sharedKey,normalizedSharedKeyAlgorithm,extractable,usages],
+'raw-secret',encapsulateBits.sharedKey,normalizedSharedKeyAlgorithm,extractable,usages,
 );
 
 constencapsulatedKey={
@@ -1469,10 +1470,10 @@ async function decapsulateKey(
 throwlazyDOMException('Unrecognized algorithm name','NotSupportedError');
 }
 
-returnReflectApply(
+returnFunctionPrototypeCall(
 importKeySync,
 this,
-['raw-secret',decapsulatedBits,normalizedSharedKeyAlgorithm,extractable,usages],
+'raw-secret',decapsulatedBits,normalizedSharedKeyAlgorithm,extractable,usages,
 );
 }