dgram: remove listeners on bind error

This avoids piling up `'listening'` event listeners if
`.bind()` fails repeatedly.
Fixes: #30209
PR-URL: #30210
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: addaleax

lib/dgram.js

@@ -211,8 +211,21 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {
 
 state.bindState=BIND_STATE_BINDING;
 
-if(arguments.length&&typeofarguments[arguments.length-1]==='function')
-this.once('listening',arguments[arguments.length-1]);
+constcb=arguments.length&&arguments[arguments.length-1];
+if(typeofcb==='function'){
+functionremoveListeners(){
+this.removeListener('error',removeListeners);
+this.removeListener('listening',onListening);
+}
+
+functiononListening(){
+removeListeners.call(this);
+cb.call(this);
+}
+
+this.on('error',removeListeners);
+this.on('listening',onListening);
+}
 
 if(portinstanceofUDP){
 replaceHandle(this,port);

test/parallel/test-dgram-bind-error-repeat.js

@@ -0,0 +1,27 @@
+'use strict';
+constcommon=require('../common');
+constdgram=require('dgram');
+
+// Regression test for https://github.com/nodejs/node/issues/30209
+// No warning should be emitted when re-trying `.bind()` on UDP sockets
+// repeatedly.
+
+process.on('warning',common.mustNotCall());
+
+constreservePortSocket=dgram.createSocket('udp4');
+reservePortSocket.bind(()=>{
+const{ port }=reservePortSocket.address();
+
+constnewSocket=dgram.createSocket('udp4');
+
+leterrors=0;
+newSocket.on('error',common.mustCall(()=>{
+if(++errors<20){
+newSocket.bind(port,common.mustNotCall());
+}else{
+newSocket.close();
+reservePortSocket.close();
+}
+},20));
+newSocket.bind(port,common.mustNotCall());
+});