test: use dynamic port instead of common.PORT

Remove common.PORT from, test-net-connect-immediate-destroy,
test-net-options-lookup, test-net-connect-local-error,
test-net-connect-handle-econnrefused, test-net-socket-destroy-twice,
test-net-better-error-messages-port-hostname, test-net-localerror,
to reduce possibility that a dynamic port used in another test will
collide with common.PORT.
Moved test-net-listen-shared-ports, test-net-better-error-messages-port
from tests/parallel to test/sequential
Refs: #12376
PR-URL: #12473
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Author: thelostone-mc

test/parallel/test-net-better-error-messages-port-hostname.js

@@ -3,12 +3,13 @@ const common = require('../common');
 constnet=require('net');
 constassert=require('assert');
 
-constc=net.createConnection(common.PORT,'***');
+// Using port 0 as hostname used is already invalid.
+constc=net.createConnection(0,'***');
 
 c.on('connect',common.mustNotCall());
 
 c.on('error',common.mustCall(function(e){
 assert.strictEqual(e.code,'ENOTFOUND');
-assert.strictEqual(e.port,common.PORT);
+assert.strictEqual(e.port,0);
 assert.strictEqual(e.hostname,'***');
 }));

test/parallel/test-net-connect-handle-econnrefused.js

@@ -3,13 +3,14 @@ const common = require('../common');
 constnet=require('net');
 constassert=require('assert');
 
-
-// Hopefully nothing is running on common.PORT
-constc=net.createConnection(common.PORT);
+constserver=net.createServer();
+server.listen(0);
+constport=server.address().port;
+constc=net.createConnection(port);
 
 c.on('connect',common.mustNotCall());
 
-c.on('error',common.mustCall(function(e){
-console.error('couldn\'t connect.');
+c.on('error',common.mustCall((e)=>{
 assert.strictEqual('ECONNREFUSED',e.code);
 }));
+server.close();

test/parallel/test-net-connect-immediate-destroy.js

@@ -2,7 +2,10 @@
 constcommon=require('../common');
 constnet=require('net');
 
-constsocket=net.connect(common.PORT,common.localhostIPv4,
-common.mustNotCall());
+constserver=net.createServer();
+server.listen(0);
+constport=server.address().port;
+constsocket=net.connect(port,common.localhostIPv4,common.mustNotCall());
 socket.on('error',common.mustNotCall());
+server.close();
 socket.destroy();

test/parallel/test-net-connect-immediate-finish.js

@@ -5,7 +5,7 @@ const net = require('net');
 
 constclient=net.connect({host: '***',port: common.PORT});
 
-client.once('error',common.mustCall(function(err){
+client.once('error',common.mustCall((err)=>{
 assert(err);
 assert.strictEqual(err.code,err.errno);
 assert.strictEqual(err.code,'ENOTFOUND');

test/parallel/test-net-connect-local-error.js

@@ -3,21 +3,25 @@ const common = require('../common');
 constassert=require('assert');
 constnet=require('net');
 
+constserver=net.createServer();
+server.listen(0);
+constport=server.address().port;
 constclient=net.connect({
-port: common.PORT+1,
-localPort: common.PORT,
+port: port+1,
+localPort: port,
 localAddress: common.localhostIPv4
 });
 
 client.on('error',common.mustCall(functiononError(err){
 assert.strictEqual(
 err.localPort,
-common.PORT,
-`${err.localPort} !== ${common.PORT} in ${err}`
+port,
+`${err.localPort} !== ${port} in ${err}`
 );
 assert.strictEqual(
 err.localAddress,
 common.localhostIPv4,
 `${err.localAddress} !== ${common.localhostIPv4} in ${err}`
 );
 }));
+server.close();

test/parallel/test-net-localerror.js

@@ -1,22 +1,23 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
 constnet=require('net');
 
+// Using port 0 as localPort / localAddress is already invalid.
 connect({
 host: 'localhost',
-port: common.PORT,
+port: 0,
 localPort: 'foobar',
 },/^TypeError:"localPort"optionshouldbeanumber:foobar$/);
 
 connect({
 host: 'localhost',
-port: common.PORT,
+port: 0,
 localAddress: 'foobar',
 },/^TypeError:"localAddress"optionmustbeavalidIP:foobar$/);
 
 functionconnect(opts,msg){
-assert.throws(function(){
+assert.throws(()=>{
 net.connect(opts);
 },msg);
 }

test/parallel/test-net-options-lookup.js

@@ -1,20 +1,21 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 constassert=require('assert');
 constnet=require('net');
 
 constexpectedError=/^TypeError:"lookup"optionshouldbeafunction$/;
 
 ['foobar',1,{},[]].forEach((input)=>connectThrows(input));
 
+// Using port 0 as lookup is emitted before connecting.
 functionconnectThrows(input){
 constopts={
 host: 'localhost',
-port: common.PORT,
+port: 0,
 lookup: input
 };
 
-assert.throws(function(){
+assert.throws(()=>{
 net.connect(opts);
 },expectedError);
 }
@@ -24,11 +25,11 @@ function connectThrows(input) {
 functionconnectDoesNotThrow(input){
 constopts={
 host: 'localhost',
-port: common.PORT,
+port: 0,
 lookup: input
 };
 
-assert.doesNotThrow(function(){
+assert.doesNotThrow(()=>{
 net.connect(opts);
 });
 }

test/parallel/test-net-socket-destroy-twice.js

@@ -2,10 +2,14 @@
 constcommon=require('../common');
 constnet=require('net');
 
-constconn=net.createConnection(common.PORT);
+constserver=net.createServer();
+server.listen(0);
+constport=server.address().port;
+constconn=net.createConnection(port);
 
-conn.on('error',common.mustCall(function(){
+conn.on('error',common.mustCall(()=>{
 conn.destroy();
 }));
 
 conn.on('close',common.mustCall(function(){}));
+server.close();