test: fix tests so they work in worker threads

Use the `cwd` option for child_process instead of `process.chdir()` to
allow tests to work with worker threads.
PR-URL: #26453
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: richardlau

test/parallel/test-cli-eval.js

@@ -34,9 +34,6 @@ const path = require('path');
 constfixtures=require('../common/fixtures');
 constnodejs=`"${process.execPath}"`;
 
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
-
 if(process.argv.length>2){
 console.log(process.argv.slice(2).join(' '));
 process.exit(0);
@@ -98,16 +95,14 @@ child.exec(`${nodejs} --print "os.platform()"`,
 }));
 
 // Module path resolve bug regression test.
-constcwd=process.cwd();
-process.chdir(path.resolve(__dirname,'../../'));
 child.exec(`${nodejs} --eval "require('./test/parallel/test-cli-eval.js')"`,
+{cwd: path.resolve(__dirname,'../../')},
 common.mustCall((err,stdout,stderr)=>{
 assert.strictEqual(err.code,42);
 assert.strictEqual(
 stdout,'Loaded as a module, exiting with status code 42.\n');
 assert.strictEqual(stderr,'');
 }));
-process.chdir(cwd);
 
 // Missing argument should not crash.
 child.exec(`${nodejs} -e`,common.mustCall((err,stdout,stderr)=>{

test/parallel/test-cli-node-options-disallowed.js

@@ -2,8 +2,6 @@
 constcommon=require('../common');
 if(process.config.variables.node_without_node_options)
 common.skip('missing NODE_OPTIONS support');
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
 
 // Test options specified by env variable.
 
@@ -12,7 +10,6 @@ const exec = require('child_process').execFile;
 
 consttmpdir=require('../common/tmpdir');
 tmpdir.refresh();
-process.chdir(tmpdir.path);
 
 disallow('--version');
 disallow('-v');
@@ -32,7 +29,7 @@ disallow('--');
 
 functiondisallow(opt){
 constenv=Object.assign({},process.env,{NODE_OPTIONS: opt});
-exec(process.execPath,{ env },common.mustCall(function(err){
+exec(process.execPath,{cwd: tmpdir.path,env },common.mustCall((err)=>{
 constmessage=err.message.split(/\r?\n/)[1];
 constexpect=`${process.execPath}: ${opt} is not allowed in NODE_OPTIONS`;
 

test/parallel/test-cli-node-options.js

@@ -2,8 +2,6 @@
 constcommon=require('../common');
 if(process.config.variables.node_without_node_options)
 common.skip('missing NODE_OPTIONS support');
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
 
 // Test options specified by env variable.
 
@@ -12,7 +10,6 @@ const exec = require('child_process').execFile;
 
 consttmpdir=require('../common/tmpdir');
 tmpdir.refresh();
-process.chdir(tmpdir.path);
 
 constprintA=require.resolve('../fixtures/printA.js');
 expect(`-r ${printA}`,'A\nB\n');
@@ -64,6 +61,7 @@ expect('--stack-trace-limit=100',
 functionexpect(opt,want,command='console.log("B")',wantsError=false){
 constargv=['-e',command];
 constopts={
+cwd: tmpdir.path,
 env: Object.assign({},process.env,{NODE_OPTIONS: opt}),
 maxBuffer: 1e6,
 };

test/parallel/test-preload-print-process-argv.js

@@ -3,31 +3,28 @@
 // This tests that process.argv is the same in the preloaded module
 // and the user module.
 
-constcommon=require('../common');
+require('../common');
 
 consttmpdir=require('../common/tmpdir');
 constassert=require('assert');
+const{ join }=require('path');
 const{ spawnSync }=require('child_process');
 constfs=require('fs');
 
-if(!common.isMainThread){
-common.skip('Cannot chdir to the tmp directory in workers');
-}
-
 tmpdir.refresh();
 
-process.chdir(tmpdir.path);
 fs.writeFileSync(
-'preload.js',
+join(tmpdir.path,'preload.js'),
 'console.log(JSON.stringify(process.argv));',
 'utf-8');
 
 fs.writeFileSync(
-'main.js',
+join(tmpdir.path,'main.js'),
 'console.log(JSON.stringify(process.argv));',
 'utf-8');
 
-constchild=spawnSync(process.execPath,['-r','./preload.js','main.js']);
+constchild=spawnSync(process.execPath,['-r','./preload.js','main.js'],
+{cwd: tmpdir.path});
 
 if(child.status!==0){
 console.log(child.stderr.toString());

test/parallel/test-preload.js

@@ -5,8 +5,6 @@ const fixtures = require('../common/fixtures');
 // Refs: https://github.com/nodejs/node/pull/2253
 if(common.isSunOS)
 common.skip('unreliable on SunOS');
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
 
 constassert=require('assert');
 constchildProcess=require('child_process');
@@ -133,9 +131,9 @@ childProcess.exec(
 );
 
 // Test that preloading with a relative path works
-process.chdir(fixtures.fixturesDir);
 childProcess.exec(
 `"${nodeBinary}" ${preloadOption(['./printA.js'])} "${fixtureB}"`,
+{cwd: fixtures.fixturesDir},
 common.mustCall(function(err,stdout,stderr){
 assert.ifError(err);
 assert.strictEqual(stdout,'A\nB\n');
@@ -145,6 +143,7 @@ if (common.isWindows) {
 // https://github.com/nodejs/node/issues/21918
 childProcess.exec(
 `"${nodeBinary}" ${preloadOption(['.\\printA.js'])} "${fixtureB}"`,
+{cwd: fixtures.fixturesDir},
 common.mustCall(function(err,stdout,stderr){
 assert.ifError(err);
 assert.strictEqual(stdout,'A\nB\n');
@@ -153,10 +152,10 @@ if (common.isWindows) {
 }
 
 // https://github.com/nodejs/node/issues/1691
-process.chdir(fixtures.fixturesDir);
 childProcess.exec(
 `"${nodeBinary}" --require `+
 `"${fixtures.path('cluster-preload.js')}" cluster-preload-test.js`,
+{cwd: fixtures.fixturesDir},
 function(err,stdout,stderr){
 assert.ifError(err);
 assert.ok(/workerterminatedwithcode43/.test(stdout));

test/parallel/test-tick-processor-arguments.js

@@ -5,20 +5,18 @@ const fs = require('fs');
 constassert=require('assert');
 const{ spawnSync }=require('child_process');
 
-if(!common.isMainThread)
-common.skip('chdir not available in workers');
 if(!common.enoughTestMem)
 common.skip('skipped due to memory requirements');
 if(common.isAIX)
 common.skip('does not work on AIX');
 
 tmpdir.refresh();
-process.chdir(tmpdir.path);
 
 // Generate log file.
-spawnSync(process.execPath,['--prof','-p','42']);
+spawnSync(process.execPath,['--prof','-p','42'],{cwd: tmpdir.path});
 
-constlogfile=fs.readdirSync('.').filter((name)=>name.endsWith('.log'))[0];
+constfiles=fs.readdirSync(tmpdir.path);
+constlogfile=files.filter((name)=>/\.log$/.test(name))[0];
 assert(logfile);
 
 // Make sure that the --preprocess argument is passed through correctly,
@@ -28,7 +26,7 @@ assert(logfile);
 const{ stdout }=spawnSync(
 process.execPath,
 ['--prof-process','--preprocess',logfile],
-{encoding: 'utf8'});
+{cwd: tmpdir.path,encoding: 'utf8'});
 
 // Make sure that the result is valid JSON.
 JSON.parse(stdout);

test/parallel/test-trace-events-environment.js

@@ -10,9 +10,6 @@ const tmpdir = require('../common/tmpdir');
 
 // This tests the emission of node.environment trace events
 
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
-
 constnames=newSet([
 'Environment',
 'RunAndClearNativeImmediates',
@@ -32,10 +29,10 @@ if (process.argv[2] === 'child') {
 setTimeout(()=>{1+1;},1);
 }else{
 tmpdir.refresh();
-process.chdir(tmpdir.path);
 
 constproc=cp.fork(__filename,
 ['child'],{
+cwd: tmpdir.path,
 execArgv: [
 '--trace-event-categories',
 'node.environment'

test/parallel/test-worker-prof.js

@@ -1,14 +1,12 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
 consttmpdir=require('../common/tmpdir');
 constfs=require('fs');
 constassert=require('assert');
+const{ join }=require('path');
 const{ spawnSync }=require('child_process');
 const{ Worker }=require('worker_threads');
 
-if(!common.isMainThread)
-common.skip('process.chdir is not available in Workers');
-
 // Test that --prof also tracks Worker threads.
 // Refs: https://github.com/nodejs/node/issues/24016
 
@@ -23,13 +21,14 @@ if (process.argv[2] === 'child') {
 }
 
 tmpdir.refresh();
-process.chdir(tmpdir.path);
-spawnSync(process.execPath,['--prof',__filename,'child']);
-constlogfiles=fs.readdirSync('.').filter((name)=>/\.log$/.test(name));
+spawnSync(process.execPath,['--prof',__filename,'child'],
+{cwd: tmpdir.path});
+constfiles=fs.readdirSync(tmpdir.path);
+constlogfiles=files.filter((name)=>/\.log$/.test(name));
 assert.strictEqual(logfiles.length,2);// Parent thread + child thread.
 
 for(constlogfileoflogfiles){
-constlines=fs.readFileSync(logfile,'utf8').split('\n');
+constlines=fs.readFileSync(join(tmpdir.path,logfile),'utf8').split('\n');
 constticks=lines.filter((line)=>/^tick,/.test(line)).length;
 
 // Test that at least 15 ticks have been recorded for both parent and child