test: refactor test-domain-abort-on-uncaught

* use common.mustCall() instead of exit handler
* use execSync instead of exec so test is reliable under load
* move from sequential to parallel
PR-URL: #14541Fixes: #11826
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Trott

…uential/test-domain-abort-on-uncaught.js …arallel/test-domain-abort-on-uncaught.jstest/sequential/test-domain-abort-on-uncaught.js renamed to test/parallel/test-domain-abort-on-uncaught.js test/sequential/test-domain-abort-on-uncaught.js renamed to test/parallel/test-domain-abort-on-uncaught.js

@@ -5,19 +5,16 @@
 // setup, the process _does not_ abort.
 
 constcommon=require('../common');
+
 constassert=require('assert');
 constdomain=require('domain');
 constchild_process=require('child_process');
 
-leterrorHandlerCalled=false;
-
 consttests=[
 functionnextTick(){
 constd=domain.create();
 
-d.once('error',function(err){
-errorHandlerCalled=true;
-});
+d.once('error',common.mustCall());
 
 d.run(function(){
 process.nextTick(function(){
@@ -29,9 +26,7 @@ const tests = [
 functiontimer(){
 constd=domain.create();
 
-d.on('error',function(err){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 setTimeout(function(){
@@ -43,9 +38,7 @@ const tests = [
 functionimmediate(){
 constd=domain.create();
 
-d.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 setImmediate(function(){
@@ -57,9 +50,7 @@ const tests = [
 functiontimerPlusNextTick(){
 constd=domain.create();
 
-d.on('error',function(err){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 setTimeout(function(){
@@ -73,9 +64,7 @@ const tests = [
 functionfirstRun(){
 constd=domain.create();
 
-d.on('error',function(err){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 thrownewError('exceptional!');
@@ -85,9 +74,7 @@ const tests = [
 functionfsAsync(){
 constd=domain.create();
 
-d.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 constfs=require('fs');
@@ -101,9 +88,7 @@ const tests = [
 constnet=require('net');
 constd=domain.create();
 
-d.on('error',function(err){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 constserver=net.createServer(function(conn){
@@ -124,9 +109,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -139,9 +122,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d2.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d2.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -154,9 +135,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d2.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d2.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -172,9 +151,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d2.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d2.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -189,9 +166,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d2.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d2.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -206,9 +181,7 @@ const tests = [
 constd=domain.create();
 constd2=domain.create();
 
-d2.on('error',functionerrorHandler(){
-errorHandlerCalled=true;
-});
+d2.on('error',common.mustCall());
 
 d.run(function(){
 d2.run(function(){
@@ -226,9 +199,6 @@ if (process.argv[2] === 'child') {
 
 tests[testIndex]();
 
-process.on('exit',functiononExit(){
-assert.strictEqual(errorHandlerCalled,true);
-});
 }else{
 
 tests.forEach(function(test,testIndex){
@@ -242,13 +212,10 @@ if (process.argv[2] === 'child') {
 testCmd+=`"${process.argv[0]}" --abort-on-uncaught-exception `+
 `"${process.argv[1]}" child ${testIndex}`;
 
-constchild=child_process.exec(testCmd);
-
-child.on('exit',functiononExit(code,signal){
-assert.strictEqual(
-code,0,`Test at index ${testIndex
-} should have exited with exit code 0 but instead exited with code ${
-code} and signal ${signal}`);
-});
+try{
+child_process.execSync(testCmd);
+}catch(e){
+assert.fail(undefined,undefined,`Test index ${testIndex} failed: ${e}`);
+}
 });
 }