tools: add some options and comments to shell.nix

PR-URL: #60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Author: aduh95

shell.nix

@@ -1,54 +1,64 @@
 {
 pkgs ? import./tools/nix/pkgs.nix{},
-loadJSBuiltinsDynamically ? true,# Load `lib/**.js` from disk instead of embedding
-withTemporal ? false,
-ncu-path ? null,# Provide this if you want to use a local version of NCU
-icu ? pkgs.icu,
-sharedLibDeps ? import./tools/nix/sharedLibDeps.nix{inheritpkgswithTemporal;},
+
+# Optional build tools / config
 ccache ? pkgs.ccache,
+loadJSBuiltinsDynamically ? true,# Load `lib/**.js` from disk instead of embedding
 ninja ? pkgs.ninja,
-devTools ? import./tools/nix/devTools.nix{inheritpkgsncu-path;},
-benchmarkTools ? import./tools/nix/benchmarkTools.nix{inheritpkgs;},
 extraConfigFlags ? [
 "--without-npm"
 "--debug-node"
-]
-++pkgs.lib.optionalswithTemporal[
-"--v8-enable-temporal-support"
 ],
+
+# Build options
+icu ? pkgs.icu,
+withAmaro ? true,
+withSQLite ? true,
+withSSL ? true,
+withTemporal ? false,
+sharedLibDeps ? import./tools/nix/sharedLibDeps.nix{
+inherit
+pkgs
+withSQLite
+withSSL
+withTemporal
+;
+},
+
+# dev tools (not needed to build Node.js, useful to maintain it)
+ncu-path ? null,# Provide this if you want to use a local version of NCU
+devTools ? import./tools/nix/devTools.nix{inheritpkgsncu-path;},
+benchmarkTools ? import./tools/nix/benchmarkTools.nix{inheritpkgs;},
 }:
 
 let
 useSharedICU=ifbuiltins.isStringicuthenicu=="system"elseicu!=null;
 useSharedAda=builtins.hasAttr"ada"sharedLibDeps;
 useSharedOpenSSL=builtins.hasAttr"openssl"sharedLibDeps;
+
+needsRustCompiler=withTemporal&&!builtins.hasAttr"temporal_capi"sharedLibDeps;
 in
 pkgs.mkShell{
 inherit(pkgs.nodejs_latest)nativeBuildInputs;
 
 buildInputs=builtins.attrValuessharedLibDeps++pkgs.lib.optionaluseSharedICUicu;
 
-packages=[
-ccache
-]
-++devTools
-++benchmarkTools
-++pkgs.lib.optionals(withTemporal&&!builtins.hasAttr"temporal_capi"sharedLibDeps)[
-pkgs.cargo
-pkgs.rustc
-];
+packages=
+pkgs.lib.optional(ccache!=null)ccache
+++devTools
+++benchmarkTools
+++pkgs.lib.optionalsneedsRustCompiler[
+pkgs.cargo
+pkgs.rustc
+];
 
-shellHook=
-if(ccache!=null)then
-''
- export CC="${pkgs.lib.getExeccache} $CC"
- export CXX="${pkgs.lib.getExeccache} $CXX"
- ''
-else
-"";
+shellHook=pkgs.lib.optionalString(ccache!=null)''
+ export CC="${pkgs.lib.getExeccache} $CC"
+ export CXX="${pkgs.lib.getExeccache} $CXX"
+ '';
 
 BUILD_WITH=if(ninja!=null)then"ninja"else"make";
-NINJA=if(ninja!=null)then"${pkgs.lib.getExeninja}"else"";
+NINJA=pkgs.lib.optionalString(ninja!=null)"${pkgs.lib.getExeninja}";
 CI_SKIP_TESTS=pkgs.lib.concatStringsSep","(
 []
 ++pkgs.lib.optionalsuseSharedAda[
@@ -70,12 +80,12 @@ pkgs.mkShell {
 )
 ]
 ++extraConfigFlags
-++pkgs.lib.optionals(ninja!=null)[
-"--ninja"
-]
-++pkgs.lib.optionalsloadJSBuiltinsDynamically[
-"--node-builtin-modules-path=${builtins.toString./.}"
-]
+++pkgs.lib.optional(!withAmaro)"--without-amaro"
+++pkgs.lib.optional(!withSQLite)"--without-sqlite"
+++pkgs.lib.optional(!withSSL)"--without-ssl"
+++pkgs.lib.optionalwithTemporal"--v8-enable-temporal-support"
+++pkgs.lib.optional(ninja!=null)"--ninja"
+++pkgs.lib.optionalloadJSBuiltinsDynamically"--node-builtin-modules-path=${builtins.toString./.}"
 ++pkgs.lib.concatMap(name: [
 "--shared-${builtins.replaceStrings["c-ares"]["cares"]name}"
 "--shared-${builtins.replaceStrings["c-ares"]["cares"]name}-libpath=${
@@ -86,4 +96,5 @@ pkgs.mkShell {
 }/include"
 ])(builtins.attrNamessharedLibDeps)
 );
+NOSQLITE=pkgs.lib.optionalString(!withSQLite)"1";
 }

tools/nix/sharedLibDeps.nix

@@ -1,5 +1,7 @@
 {
 pkgs ? import./pkgs.nix{},
+withSQLite ? true,
+withSSL ? true,
 withTemporal ? false,
 }:
 {
@@ -13,12 +15,16 @@
 ngtcp2
 simdjson
 simdutf
-sqlite
 uvwasi
 zlib
 zstd
 ;
 http-parser=pkgs.llhttp;
+}
+//(pkgs.lib.optionalAttrswithSQLite{
+inherit(pkgs)sqlite;
+})
+//(pkgs.lib.optionalAttrswithSSL{
 openssl=pkgs.openssl.overrideAttrs(old: {
 version="3.5.4";
 src=pkgs.fetchurl{
@@ -36,7 +42,7 @@
 "dev"
 ];
 });
-}
+})
 //(pkgs.lib.optionalAttrswithTemporal{
 inherit(pkgs)temporal_capi;
 })