perf_hooks: always set bootstrapComplete

PR-URL: #20768
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: jasnell

lib/internal/bootstrap/node.js

@@ -157,12 +157,12 @@
 // To allow people to extend Node in different ways, this hook allows
 // one to drop a file lib/_third_party_main.js into the build
 // directory which will be executed instead of Node's normal loading.
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 process.nextTick(function(){
 perf.markMilestone(NODE_PERFORMANCE_MILESTONE_THIRD_PARTY_MAIN_START);
 NativeModule.require('_third_party_main');
 perf.markMilestone(NODE_PERFORMANCE_MILESTONE_THIRD_PARTY_MAIN_END);
 });
-
 }elseif(process.argv[1]==='inspect'||process.argv[1]==='debug'){
 if(process.argv[1]==='debug'){
 process.emitWarning(
@@ -171,13 +171,14 @@
 }
 
 // Start the debugger agent.
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 process.nextTick(function(){
 NativeModule.require('internal/deps/node-inspect/lib/_inspect').start();
 });
 
 }elseif(process.profProcess){
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 NativeModule.require('internal/v8_prof_processor');
-
 }else{
 // There is user code to be run.
 
@@ -208,6 +209,7 @@
  addBuiltinLibsToObject
 }=NativeModule.require('internal/modules/cjs/helpers');
 addBuiltinLibsToObject(global);
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 evalScript('[eval]');
 }elseif(process.argv[1]&&process.argv[1]!=='-'){
 perf.markMilestone(NODE_PERFORMANCE_MILESTONE_MODULE_LOAD_START);
@@ -232,6 +234,7 @@
 checkScriptSyntax(source,filename);
 process.exit(0);
 }
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 CJSModule.runMain();
 }else{
 perf.markMilestone(NODE_PERFORMANCE_MILESTONE_MODULE_LOAD_START);
@@ -262,6 +265,7 @@
 
 if(process._eval!=null){
 // User passed '-e' or '--eval'
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 evalScript('[eval]');
 }
 }else{
@@ -278,6 +282,7 @@
 checkScriptSyntax(code,'[stdin]');
 }else{
 process._eval=code;
+perf.markMilestone(NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE);
 evalScript('[stdin]');
 }
 });

test/sequential/test-performance.js

@@ -74,7 +74,7 @@ checkNodeTiming({
 duration: {around: performance.now()},
 nodeStart: {around: 0},
 v8Start: {around: 0},
-bootstrapComplete: -1,
+bootstrapComplete: {around: inited},
 environment: {around: 0},
 loopStart: -1,
 loopExit: -1,