test: use mustCall in place of countdown in timers test

Trott · MylesBorins · commit 2f73e6eee093 · 2020-03-24T12:25:23.000-04:00
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: #32416 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-timers-immediate-unref.js b/test/parallel/test-timers-immediate-unref.js
@@ -1,8 +1,6 @@
 'use strict';
 
 const common = require('../common');
-const Countdown = require('../common/countdown');
-
 const assert = require('assert');
 
 const immediate = setImmediate(() => {});
@@ -16,12 +14,10 @@ clearImmediate(immediate);
 setImmediate(common.mustCall(firstStep)).ref().unref().unref().ref();
 
 function firstStep() {
- const countdown =
- new Countdown(2, common.mustCall(() => setImmediate(secondStep)));
 // Unrefed setImmediate executes if it was unrefed but something else keeps
 // the loop open
- setImmediate(() => countdown.dec()).unref();
- setTimeout(() => countdown.dec(), 50);
+ setImmediate(common.mustCall()).unref();
+ setTimeout(common.mustCall(() => { setImmediate(secondStep); }), 0);
 }
 
 function secondStep() {

-Original file line number
+Diff line change
@@ @@ -1,8 +1,6 @@ @@
 'use strict';
 constcommon=require('../common');
 -constCountdown=require('../common/countdown');
+-
 constassert=require('assert');
 constimmediate=setImmediate(()=>{});
 setImmediate(common.mustCall(firstStep)).ref().unref().unref().ref();
 functionfirstStep(){
 -constcountdown=
 -newCountdown(2,common.mustCall(()=>setImmediate(secondStep)));
 // Unrefed setImmediate executes if it was unrefed but something else keeps
 // the loop open
 -setImmediate(()=>countdown.dec()).unref();
 -setTimeout(()=>countdown.dec(),50);
 +setImmediate(common.mustCall()).unref();
 +setTimeout(common.mustCall(()=>{setImmediate(secondStep);}),0);
+}
 functionsecondStep(){