fs: fix typings

PR-URL: #53626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: anonrig

lib/fs.js

@@ -254,7 +254,7 @@ function exists(path, callback) {
 validateFunction(callback,'cb');
 
 functionsuppressedCallback(err){
-callback(err ? false : true);
+callback(!err);
 }
 
 try{
@@ -759,8 +759,8 @@ function readSync(fd, buffer, offsetOrOptions, length, position) {
  * @param {(
  * err?: Error,
  * bytesRead?: number,
- * buffers?: ArrayBufferView[];
- * ) => any} callback
+ * buffers?: ArrayBufferView[]
+ * ) => any} callback
  * @returns {void}
  */
 functionreadv(fd,buffers,position,callback){
@@ -813,9 +813,9 @@ function readvSync(fd, buffers, position) {
  * @param {number | null} [position]
  * @param {(
  * err?: Error,
- * bytesWritten?: number;
+ * bytesWritten?: number,
  * buffer?: Buffer | TypedArray | DataView
- * ) => any} callback
+ * ) => any} callback
  * @returns {void}
  */
 functionwrite(fd,buffer,offsetOrOptions,length,position,callback){
@@ -891,6 +891,8 @@ ObjectDefineProperty(write, kCustomPromisifyArgsSymbol,
  * length?: number;
  * position?: number | null;
  * }} [offsetOrOptions]
+ * @param {number} [length]
+ * @param {number} [position]
  * @returns {number}
  */
 functionwriteSync(fd,buffer,offsetOrOptions,length,position){
@@ -1084,14 +1086,11 @@ function truncateSync(path, len) {
 }
 // Allow error to be thrown, but still close fd.
 constfd=fs.openSync(path,'r+');
-letret;
-
 try{
-ret=fs.ftruncateSync(fd,len);
+fs.ftruncateSync(fd,len);
 }finally{
 fs.closeSync(fd);
 }
-returnret;
 }
 
 /**
@@ -1450,8 +1449,8 @@ function readdirSyncRecursive(basePath, options) {
  * }} [options]
  * @param {(
  * err?: Error,
- * files?: string[] | Buffer[] | Dirent[];
- * ) => any} callback
+ * files?: string[] | Buffer[] | Dirent[]
+ * ) => any} callback
  * @returns {void}
  */
 functionreaddir(path,options,callback){
@@ -1957,13 +1956,11 @@ function lchmodSync(path, mode) {
 
 // Prefer to return the chmod error, if one occurs,
 // but still try to close, and report closing errors if they occur.
-letret;
 try{
-ret=fs.fchmodSync(fd,mode);
+fs.fchmodSync(fd,mode);
 }finally{
 fs.closeSync(fd);
 }
-returnret;
 }
 
 /**
@@ -2838,7 +2835,7 @@ function realpath(p, options, callback) {
 
 // On windows, check that the root exists. On unix there is no need.
 if(isWindows&&!knownHard.has(base)){
-fs.lstat(base,(err,stats)=>{
+fs.lstat(base,(err)=>{
 if(err)returncallback(err);
 knownHard.add(base);
 LOOP();

typings/internalBinding/fs.d.ts

@@ -57,7 +57,7 @@ declare namespace InternalFSBinding {
 }
 
 functionaccess(path: StringOrBuffer,mode: number,req: FSReqCallback): void;
-functionaccess(path: StringOrBuffer,mode: number,req: undefined,ctx: FSSyncContext): void;
+functionaccess(path: StringOrBuffer,mode: number): void;
 functionaccess(path: StringOrBuffer,mode: number,usePromises: typeofkUsePromises): Promise<void>;
 
 functionchmod(path: string,mode: number,req: FSReqCallback): void;
@@ -70,7 +70,7 @@ declare namespace InternalFSBinding {
 functionchown(path: string,uid: number,gid: number): void;
 
 functionclose(fd: number,req: FSReqCallback): void;
-functionclose(fd: number,req: undefined,ctx: FSSyncContext): void;
+functionclose(fd: number): void;
 
 functioncopyFile(src: StringOrBuffer,dest: StringOrBuffer,mode: number,req: FSReqCallback): void;
 functioncopyFile(src: StringOrBuffer,dest: StringOrBuffer,mode: number,req: undefined,ctx: FSSyncContext): void;
@@ -154,7 +154,7 @@ declare namespace InternalFSBinding {
 functionmkdir(path: string,mode: number,recursive: false,usePromises: typeofkUsePromises): Promise<void>;
 
 functionopen(path: StringOrBuffer,flags: number,mode: number,req: FSReqCallback<number>): void;
-functionopen(path: StringOrBuffer,flags: number,mode: number,req: undefined,ctx: FSSyncContext): number;
+functionopen(path: StringOrBuffer,flags: number,mode: number): number;
 
 functionopenFileHandle(path: StringOrBuffer,flags: number,mode: number,usePromises: typeofkUsePromises): Promise<FileHandle>;
 
@@ -176,6 +176,8 @@ declare namespace InternalFSBinding {
 functionreaddir(path: StringOrBuffer,encoding: unknown,withFileTypes: true,usePromises: typeofkUsePromises): Promise<[string[],number[]]>;
 functionreaddir(path: StringOrBuffer,encoding: unknown,withFileTypes: false,usePromises: typeofkUsePromises): Promise<string[]>;
 
+functionreadFileUtf8(path: StringOrBuffer,flags: number): string;
+
 functionreadlink(path: StringOrBuffer,encoding: unknown,req: FSReqCallback<string|Buffer>): void;
 functionreadlink(path: StringOrBuffer,encoding: unknown,req: undefined,ctx: FSSyncContext): string|Buffer;
 functionreadlink(path: StringOrBuffer,encoding: unknown,usePromises: typeofkUsePromises): Promise<string|Buffer>;
@@ -273,6 +275,7 @@ export interface FsBinding {
 read: typeofInternalFSBinding.read;
 readBuffers: typeofInternalFSBinding.readBuffers;
 readdir: typeofInternalFSBinding.readdir;
+readFileUtf8: typeofInternalFSBinding.readFileUtf8;
 readlink: typeofInternalFSBinding.readlink;
 realpath: typeofInternalFSBinding.realpath;
 rename: typeofInternalFSBinding.rename;