src: fix json payload from inspector

Fix the `webSocketDebuggerUrl` and `devtoolsFrontendUrl` returned by
v8_inspector in /json HTTP endpoint to work with 3rd party clients.
Fixes: #7227
PR-URL: #7232
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

Author: Myles Borins

src/inspector_agent.cc

@@ -29,13 +29,15 @@ namespace node {
 namespace {
 
 constcharDEVTOOLS_PATH[] = "/node";
+constcharDEVTOOLS_HASH[] = "521e5b7e2b7cc66b4006a8a54cb9c4e57494a5ef";
 
 voidPrintDebuggerReadyMessage(int port) {
 fprintf(stderr, "Debugger listening on port %d.\n"
 "To start debugging, open the following URL in Chrome:\n"
 " chrome-devtools://devtools/remote/serve_file/"
-"@521e5b7e2b7cc66b4006a8a54cb9c4e57494a5ef/inspector.html?"
-"experiments=true&v8only=true&ws=localhost:%d/node\n", port, port);
+"@%s/inspector.html?"
+"experiments=true&v8only=true&ws=localhost:%d/node\n",
+ port, DEVTOOLS_HASH, port);
 }
 
 boolAcceptsConnection(inspector_socket_t* socket, constchar* path) {
@@ -89,18 +91,19 @@ void SendVersionResponse(inspector_socket_t* socket) {
 SendHttpResponse(socket, buffer, len);
 }
 
-voidSendTargentsListResponse(inspector_socket_t* socket) {
+voidSendTargentsListResponse(inspector_socket_t* socket, int port) {
 constcharLIST_RESPONSE_TEMPLATE[] =
 "[ {"
 "\"description\": \"node.js instance\","
 "\"devtoolsFrontendUrl\": "
 "\"https://chrome-devtools-frontend.appspot.com/serve_file/"
-"@4604d24a75168768584760ba56d175507941852f/inspector.html\","
+"@%s/inspector.html?experiments=true&v8only=true"
+"&ws=localhost:%d%s\","
 "\"faviconUrl\": \"https://nodejs.org/static/favicon.ico\","
 "\"id\": \"%d\","
 "\"title\": \"%s\","
 "\"type\": \"node\","
-"\"webSocketDebuggerUrl\": \"ws://%s\""
+"\"webSocketDebuggerUrl\": \"ws://localhost:%d%s\""
 "} ]";
 char buffer[sizeof(LIST_RESPONSE_TEMPLATE) + 4096];
 char title[2048]; // uv_get_process_title trims the title if too long
@@ -114,12 +117,13 @@ void SendTargentsListResponse(inspector_socket_t* socket) {
  c++;
  }
 size_t len = snprintf(buffer, sizeof(buffer), LIST_RESPONSE_TEMPLATE,
-getpid(), title, DEVTOOLS_PATH);
+DEVTOOLS_HASH, port, DEVTOOLS_PATH, getpid(),
+ title, port, DEVTOOLS_PATH);
 ASSERT_LT(len, sizeof(buffer));
 SendHttpResponse(socket, buffer, len);
 }
 
-boolRespondToGet(inspector_socket_t* socket, constchar* path) {
+boolRespondToGet(inspector_socket_t* socket, constchar* path, int port) {
 constcharPATH[] = "/json";
 constcharPATH_LIST[] = "/json/list";
 constcharPATH_VERSION[] = "/json/version";
@@ -128,7 +132,7 @@ bool RespondToGet(inspector_socket_t* socket, const char* path) {
 SendVersionResponse(socket);
  } elseif (!strncmp(PATH_LIST, path, sizeof(PATH_LIST)) ||
  !strncmp(PATH, path, sizeof(PATH))) {
-SendTargentsListResponse(socket);
+SendTargentsListResponse(socket, port);
  } elseif (!strncmp(path, PATH_ACTIVATE, sizeof(PATH_ACTIVATE) - 1) &&
 atoi(path + (sizeof(PATH_ACTIVATE) - 1)) == getpid()) {
 constcharTARGET_ACTIVATED[] = "Target activated";
@@ -348,7 +352,7 @@ bool Agent::OnInspectorHandshakeIO(inspector_socket_t* socket,
  Agent* agent = static_cast<Agent*>(socket->data);
 switch (state) {
 casekInspectorHandshakeHttpGet:
-returnRespondToGet(socket, path);
+returnRespondToGet(socket, path, agent->port_);
 casekInspectorHandshakeUpgrading:
 returnAcceptsConnection(socket, path);
 casekInspectorHandshakeUpgraded: