assert: differentiate cases where cause is undefined or missing

PR-URL: #55738
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: aduh95

lib/internal/assert/assertion_error.js

@@ -9,6 +9,7 @@ const {
  ObjectAssign,
  ObjectDefineProperty,
  ObjectGetPrototypeOf,
+ ObjectPrototypeHasOwnProperty,
  String,
  StringPrototypeRepeat,
  StringPrototypeSlice,
@@ -49,8 +50,8 @@ function copyError(source) {
 __proto__: null,
 value: source.message,
 });
-if(source.cause!==undefined){
-letcause=source.cause;
+if(ObjectPrototypeHasOwnProperty(source,'cause')){
+let{cause }=source;
 
 if(isError(cause)){
 cause=copyError(cause);

lib/internal/util/comparisons.js

@@ -27,6 +27,7 @@ const {
 
 const{ compare }=internalBinding('buffer');
 constassert=require('internal/assert');
+const{ isError }=require('internal/util');
 consttypes=require('internal/util/types');
 const{
  isAnyArrayBuffer,
@@ -232,10 +233,10 @@ function innerDeepEqual(val1, val2, strict, memos) {
 if(!isAnyArrayBuffer(val2)||!areEqualArrayBuffers(val1,val2)){
 returnfalse;
 }
-}elseif(isNativeError(val1)||val1instanceofError){
+}elseif(isError(val1)){
 // Do not compare the stack as it might differ even though the error itself
 // is otherwise identical.
-if(!isNativeError(val2)&&!(val2instanceofError)){
+if(!isError(val2)){
 returnfalse;
 }
 
@@ -249,7 +250,9 @@ function innerDeepEqual(val1, val2, strict, memos) {
 (name1Enumerable!==ObjectPrototypePropertyIsEnumerable(val2,'name')||
 (!name1Enumerable&&val1.name!==val2.name))||
 (cause1Enumerable!==ObjectPrototypePropertyIsEnumerable(val2,'cause')||
-(!cause1Enumerable&&!innerDeepEqual(val1.cause,val2.cause,strict,memos)))||
+(!cause1Enumerable&&(
+ObjectPrototypeHasOwnProperty(val1,'cause')!==ObjectPrototypeHasOwnProperty(val2,'cause')||
+!innerDeepEqual(val1.cause,val2.cause,strict,memos))))||
 (errors1Enumerable!==ObjectPrototypePropertyIsEnumerable(val2,'errors')||
 (!errors1Enumerable&&!innerDeepEqual(val1.errors,val2.errors,strict,memos)))){
 returnfalse;

test/parallel/test-assert-deep-with-error.js

@@ -8,13 +8,26 @@ const defaultStartMessage = 'Expected values to be strictly deep-equal:\n' +
 '\n';
 
 test('Handle error causes',()=>{
+assert.deepStrictEqual(newError('a',{cause: newError('x')}),newError('a',{cause: newError('x')}));
+assert.deepStrictEqual(
+newError('a',{cause: newRangeError('x')}),
+newError('a',{cause: newRangeError('x')}),
+);
+
 assert.throws(()=>{
 assert.deepStrictEqual(newError('a',{cause: newError('x')}),newError('a',{cause: newError('y')}));
 },{message: defaultStartMessage+' [Error: a] {\n'+
 '+ [cause]: [Error: x]\n'+
 '- [cause]: [Error: y]\n'+
 ' }\n'});
 
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a',{cause: newError('x')}),newError('a',{cause: newTypeError('x')}));
+},{message: defaultStartMessage+' [Error: a] {\n'+
+'+ [cause]: [Error: x]\n'+
+'- [cause]: [TypeError: x]\n'+
+' }\n'});
+
 assert.throws(()=>{
 assert.deepStrictEqual(newError('a'),newError('a',{cause: newError('y')}));
 },{message: defaultStartMessage+'+ [Error: a]\n'+
@@ -37,3 +50,33 @@ test('Handle error causes', () => {
 newError('a',{cause: {prop: 'a different value'}})
 );
 });
+
+test('Handle undefined causes',()=>{
+assert.deepStrictEqual(newError('a',{cause: undefined}),newError('a',{cause: undefined}));
+
+assert.notDeepStrictEqual(newError('a',{cause: 'undefined'}),newError('a',{cause: undefined}));
+assert.notDeepStrictEqual(newError('a',{cause: undefined}),newError('a'));
+assert.notDeepStrictEqual(newError('a'),newError('a',{cause: undefined}));
+
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a'),newError('a',{cause: undefined}));
+},{message: defaultStartMessage+
+'+ [Error: a]\n'+
+'- [Error: a] {\n'+
+'- [cause]: undefined\n'+
+'- }\n'});
+
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a',{cause: undefined}),newError('a'));
+},{message: defaultStartMessage+
+'+ [Error: a] {\n'+
+'+ [cause]: undefined\n'+
+'+ }\n'+
+'- [Error: a]\n'});
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a',{cause: undefined}),newError('a',{cause: 'undefined'}));
+},{message: defaultStartMessage+' [Error: a] {\n'+
+'+ [cause]: undefined\n'+
+'- [cause]: \'undefined\'\n'+
+' }\n'});
+});