path: remove StringPrototypeCharCodeAt from posix.extname

avivkeller · targos · commit 309cb1cbd217 · 2024-10-02T16:04:14.000+02:00
PR-URL: #54546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/path.js b/lib/path.js
@@ -1463,8 +1463,8 @@ const posix = {
 // after any path separator we find
 let preDotState = 0;
 for (let i = path.length - 1; i >= 0; --i) {
- const code = StringPrototypeCharCodeAt(path, i);
- if (code === CHAR_FORWARD_SLASH) {
+ const char = path[i];
+ if (char === '/') {
 // If we reached a path separator that was not part of a set of path
 // separators at the end of the string, stop now
 if (!matchedSlash) {
@@ -1479,7 +1479,7 @@ const posix = {
 matchedSlash = false;
 end = i + 1;
 }
- if (code === CHAR_DOT) {
+ if (char === '.') {
 // If this is our first dot, mark it as the start of our extension
 if (startDot === -1)
 startDot = i;

-Original file line number
+Diff line change
 // after any path separator we find
 letpreDotState=0;
 for(leti=path.length-1;i>=0;--i){
 -constcode=StringPrototypeCharCodeAt(path,i);
 -if(code===CHAR_FORWARD_SLASH){
 +constchar=path[i];
 +if(char==='/'){
 // If we reached a path separator that was not part of a set of path
 // separators at the end of the string, stop now
 if(!matchedSlash){
 matchedSlash=false;
 end=i+1;
+}
 -if(code===CHAR_DOT){
 +if(char==='.'){
 // If this is our first dot, mark it as the start of our extension
 if(startDot===-1)
 startDot=i;