test_runner: fix line feed escaping in JUnit

Replaces line feed characters with the correct character reference in
XML attribute values.
PR-URL: #60274
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Author: AlexCannonball

lib/internal/test_runner/reporter/junit.js

@@ -19,11 +19,11 @@ const inspectOptions = { __proto__: null, colors: false, breakLength: Infinity }
 constHOSTNAME=hostname();
 
 functionescapeAttribute(s=''){
-returnescapeContent(RegExpPrototypeSymbolReplace(/"/g,RegExpPrototypeSymbolReplace(/\n/g,s,''),'"'));
+returnescapeContent(RegExpPrototypeSymbolReplace(/"/g,RegExpPrototypeSymbolReplace(/\n/g,s,'
'),'"'));
 }
 
 functionescapeContent(s=''){
-returnRegExpPrototypeSymbolReplace(/</g,RegExpPrototypeSymbolReplace(/&/g,s,'&amp;'),'&lt;');
+returnRegExpPrototypeSymbolReplace(/</g,RegExpPrototypeSymbolReplace(/(&)(?!#\d{1,7};)/g,s,'&amp;'),'&lt;');
 }
 
 functionescapeComment(s=''){
@@ -137,7 +137,7 @@ module.exports = async function* junitReporter(source) {
 __proto__: null,
 nesting: event.data.nesting+1,
 tag: 'failure',
-attrs: {__proto__: null,type: error?.failureType||error?.code,message: error?.message??''},
+attrs: {__proto__: null,type: error?.failureType||error?.code,message: error?.message.trim()??''},
 children: [inspectWithNoCustomRetry(error,inspectOptions)],
 });
 currentTest.failures=1;

test/fixtures/test-runner/output/junit_reporter.snapshot

@@ -101,8 +101,8 @@
 }
  </failure>
 	</testcase>
-	<testcasename="async assertion fail"time="*"classname="test"file="*"failure="Expected values to be strictly equal:true !== false">
- <failuretype="testCodeFailure"message="Expected values to be strictly equal:true !== false">
+	<testcasename="async assertion fail"time="*"classname="test"file="*"failure="Expected values to be strictly equal:&#10;&#10;true !== false&#10;">
+ <failuretype="testCodeFailure"message="Expected values to be strictly equal:&#10;&#10;true !== false">
 [Error [ERR_TEST_FAILURE]: Expected values to be strictly equal:
 
 true !== false
@@ -316,8 +316,8 @@ Error [ERR_TEST_FAILURE]: thrown from callback async throw
 [Error [ERR_TEST_FAILURE]: customized] { code: 'ERR_TEST_FAILURE', failureType: 'testCodeFailure', cause: customized }
  </failure>
 	</testcase>
-	<testcasename="custom inspect symbol that throws fail"time="*"classname="test"file="*"failure="{ foo: 1, Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]}">
- <failuretype="testCodeFailure"message="{ foo: 1, Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]}">
+	<testcasename="custom inspect symbol that throws fail"time="*"classname="test"file="*"failure="{&#10; foo: 1,&#10; Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]&#10;}">
+ <failuretype="testCodeFailure"message="{&#10; foo: 1,&#10; Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]&#10;}">
 [Error [ERR_TEST_FAILURE]: {
  foo: 1,
  Symbol(nodejs.util.inspect.custom): [Function: [nodejs.util.inspect.custom]]
@@ -413,8 +413,8 @@ Error [ERR_TEST_FAILURE]: bar
 }
  </failure>
 	</testcase>
-	<testcasename="assertion errors display actual and expected properly"time="*"classname="test"file="*"failure="Expected values to be loosely deep-equal:{ bar: 1, baz: { date: 1970-01-01T00:00:00.000Z, null: null, number: 1, string: 'Hello', undefined: undefined }, boo: [ 1 ], foo: 1}should loosely deep-equal{ baz: { date: 1970-01-01T00:00:00.000Z, null: null, number: 1, string: 'Hello', undefined: undefined }, boo: [ 1 ], circular: &lt;ref *1> { bar: 2, c: [Circular *1] }}">
- <failuretype="testCodeFailure"message="Expected values to be loosely deep-equal:{ bar: 1, baz: { date: 1970-01-01T00:00:00.000Z, null: null, number: 1, string: 'Hello', undefined: undefined }, boo: [ 1 ], foo: 1}should loosely deep-equal{ baz: { date: 1970-01-01T00:00:00.000Z, null: null, number: 1, string: 'Hello', undefined: undefined }, boo: [ 1 ], circular: &lt;ref *1> { bar: 2, c: [Circular *1] }}">
+	<testcasename="assertion errors display actual and expected properly"time="*"classname="test"file="*"failure="Expected values to be loosely deep-equal:&#10;&#10;{&#10; bar: 1,&#10; baz: {&#10; date: 1970-01-01T00:00:00.000Z,&#10; null: null,&#10; number: 1,&#10; string: 'Hello',&#10; undefined: undefined&#10; },&#10; boo: [&#10; 1&#10; ],&#10; foo: 1&#10;}&#10;&#10;should loosely deep-equal&#10;&#10;{&#10; baz: {&#10; date: 1970-01-01T00:00:00.000Z,&#10; null: null,&#10; number: 1,&#10; string: 'Hello',&#10; undefined: undefined&#10; },&#10; boo: [&#10; 1&#10; ],&#10; circular: &lt;ref *1> {&#10; bar: 2,&#10; c: [Circular *1]&#10; }&#10;}">
+ <failuretype="testCodeFailure"message="Expected values to be loosely deep-equal:&#10;&#10;{&#10; bar: 1,&#10; baz: {&#10; date: 1970-01-01T00:00:00.000Z,&#10; null: null,&#10; number: 1,&#10; string: 'Hello',&#10; undefined: undefined&#10; },&#10; boo: [&#10; 1&#10; ],&#10; foo: 1&#10;}&#10;&#10;should loosely deep-equal&#10;&#10;{&#10; baz: {&#10; date: 1970-01-01T00:00:00.000Z,&#10; null: null,&#10; number: 1,&#10; string: 'Hello',&#10; undefined: undefined&#10; },&#10; boo: [&#10; 1&#10; ],&#10; circular: &lt;ref *1> {&#10; bar: 2,&#10; c: [Circular *1]&#10; }&#10;}">
 [Error [ERR_TEST_FAILURE]: Expected values to be loosely deep-equal:
 
 {