esm: avoid accessing lazy getters for urls

PR-URL: #47542
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: anonrig

lib/internal/modules/esm/resolve.js

@@ -994,16 +994,20 @@ function resolveAsCommonJS(specifier, parentURL) {
 // TODO(@JakobJingleheimer): de-dupe `specifier` & `parsed`
 functioncheckIfDisallowedImport(specifier,parsed,parsedParentURL){
 if(parsedParentURL){
+// Avoid accessing the `protocol` property due to the lazy getters.
+constparentProtocol=parsedParentURL.protocol;
 if(
-parsedParentURL.protocol==='http:'||
-parsedParentURL.protocol==='https:'
+parentProtocol==='http:'||
+parentProtocol==='https:'
 ){
 if(shouldBeTreatedAsRelativeOrAbsolutePath(specifier)){
+// Avoid accessing the `protocol` property due to the lazy getters.
+constparsedProtocol=parsed?.protocol;
 // data: and blob: disallowed due to allowing file: access via
 // indirection
-if(parsed&&
-parsed.protocol!=='https:'&&
-parsed.protocol!=='http:'
+if(parsedProtocol&&
+parsedProtocol!=='https:'&&
+parsedProtocol!=='http:'
 ){
 thrownewERR_NETWORK_IMPORT_DISALLOWED(
 specifier,
@@ -1033,22 +1037,26 @@ function checkIfDisallowedImport(specifier, parsed, parsedParentURL) {
 }
 
 functionthrowIfUnsupportedURLProtocol(url){
-if(url.protocol!=='file:'&&url.protocol!=='data:'&&
-url.protocol!=='node:'){
+// Avoid accessing the `protocol` property due to the lazy getters.
+constprotocol=url.protocol;
+if(protocol!=='file:'&&protocol!=='data:'&&
+protocol!=='node:'){
 thrownewERR_UNSUPPORTED_ESM_URL_SCHEME(url);
 }
 }
 
 functionthrowIfUnsupportedURLScheme(parsed,experimentalNetworkImports){
+// Avoid accessing the `protocol` property due to the lazy getters.
+constprotocol=parsed?.protocol;
 if(
-parsed&&
-parsed.protocol!=='file:'&&
-parsed.protocol!=='data:'&&
+protocol&&
+protocol!=='file:'&&
+protocol!=='data:'&&
 (
 !experimentalNetworkImports||
 (
-parsed.protocol!=='https:'&&
-parsed.protocol!=='http:'
+protocol!=='https:'&&
+protocol!=='http:'
 )
 )
 ){
@@ -1104,11 +1112,13 @@ async function defaultResolve(specifier, context = {}) {
 parsed=newURL(specifier);
 }
 
-if(parsed.protocol==='data:'||
+// Avoid accessing the `protocol` property due to the lazy getters.
+constprotocol=parsed.protocol;
+if(protocol==='data:'||
 (experimentalNetworkImports&&
 (
-parsed.protocol==='https:'||
-parsed.protocol==='http:'
+protocol==='https:'||
+protocol==='http:'
 )
 )
 ){