test: invalid chars in http client path

lucamaraschi · MylesBorins · commit 31dea5c3191b · 2017-04-18T20:02:17.000-04:00
This test adds coverage for all the characters which are considered invalid in a http path. PR-URL: #11964 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-http-invalid-path-chars.js b/test/parallel/test-http-invalid-path-chars.js
@@ -0,0 +1,20 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+
+const expectedError = /^TypeError: Request path contains unescaped characters$/;
+const theExperimentallyDeterminedNumber = 39;
+
+function fail(path) {
+ assert.throws(() => {
+ http.request({ path }, common.fail);
+ }, expectedError);
+}
+
+for (let i = 0; i <= theExperimentallyDeterminedNumber; i++) {
+ const prefix = 'a'.repeat(i);
+ for (let i = 0; i <= 32; i++) {
+ fail(prefix + String.fromCodePoint(i));
+ }
+}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,20 @@ @@
 +'use strict';
 +constcommon=require('../common');
 +constassert=require('assert');
 +consthttp=require('http');
++
 +constexpectedError=/^TypeError:Requestpathcontainsunescapedcharacters$/;
 +consttheExperimentallyDeterminedNumber=39;
++
 +functionfail(path){
 +assert.throws(()=>{
 +http.request({ path },common.fail);
 +},expectedError);
 +}
++
 +for(leti=0;i<=theExperimentallyDeterminedNumber;i++){
 +constprefix='a'.repeat(i);
 +for(leti=0;i<=32;i++){
 +fail(prefix+String.fromCodePoint(i));
 +}
 +}