buffer: fix validation of options in Blob constructor

PR-URL: #45156
Refs: https://webidl.spec.whatwg.org/#es-dictionary
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: aduh95

lib/internal/blob.js

@@ -61,8 +61,8 @@ const {
 }=require('internal/errors');
 
 const{
- validateObject,
  isUint32,
+ validateDictionary,
 }=require('internal/validators');
 
 constkHandle=Symbol('kHandle');
@@ -138,17 +138,17 @@ class Blob {
  * }} [options]
  * @constructs {Blob}
  */
-constructor(sources=[],options=kEmptyObject){
+constructor(sources=[],options){
 if(sources===null||
 typeofsources[SymbolIterator]!=='function'||
 typeofsources==='string'){
 thrownewERR_INVALID_ARG_TYPE('sources','a sequence',sources);
 }
-validateObject(options,'options');
+validateDictionary(options,'options');
 let{
  type ='',
  endings ='transparent',
-}=options;
+}=options??kEmptyObject;
 
 endings=`${endings}`;
 if(endings!=='transparent'&&endings!=='native')

lib/internal/validators.js

@@ -257,6 +257,25 @@ const validateObject = hideStackFrames(
 }
 });
 
+/**
+ * @callback validateDictionary - We are using the Web IDL Standard definition
+ * of "dictionary" here, which means any value
+ * whose Type is either Undefined, Null, or
+ * Object (which includes functions).
+ * @param {*} value
+ * @param {string} name
+ * @see https://webidl.spec.whatwg.org/#es-dictionary
+ * @see https://tc39.es/ecma262/#table-typeof-operator-results
+ */
+
+/** @type {validateDictionary} */
+constvalidateDictionary=hideStackFrames(
+(value,name)=>{
+if(value!=null&&typeofvalue!=='object'&&typeofvalue!=='function'){
+thrownewERR_INVALID_ARG_TYPE(name,'a dictionary',value);
+}
+});
+
 /**
  * @callback validateArray
  * @param {*} value
@@ -511,6 +530,7 @@ module.exports = {
  validateBooleanArray,
  validateBoolean,
  validateBuffer,
+ validateDictionary,
  validateEncoding,
  validateFunction,
  validateInt32,

test/parallel/test-blob.js

@@ -287,3 +287,32 @@ assert.throws(() => new Blob({}), {
 assert.strictEqual(blob.size,28);
 assert.strictEqual(blob.type,'');
 })().then(common.mustCall());
+
+{
+// Testing the defaults
+[undefined,null,Object.create(null),{type: undefined},{
+gettype(){},// eslint-disable-line getter-return
+}].forEach((options)=>{
+assert.strictEqual(
+newBlob([],options).type,
+newBlob([]).type,
+);
+});
+
+Reflect.defineProperty(Object.prototype,'type',{
+__proto__: null,
+configurable: true,
+get: common.mustCall(()=>3,7),
+});
+
+[{},[],()=>{},Number,newNumber(),newString(),newBoolean()].forEach(
+(options)=>{
+assert.strictEqual(newBlob([],options).type,'3');
+},
+);
+[0,'',true,Symbol(),0n].forEach((options)=>{
+assert.throws(()=>newBlob([],options),{code: 'ERR_INVALID_ARG_TYPE'});
+});
+
+deleteObject.prototype.type;
+}