test: refactor tls test to use fixtres.readSync

brianoconnell · MylesBorins · commit 33f2fff52b77 · 2017-11-16T18:17:03.000-05:00
PR-URL: #16816 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/test/parallel/test-tls-hello-parser-failure.js b/test/parallel/test-tls-hello-parser-failure.js
@@ -22,6 +22,10 @@
 'use strict';
 
 const common = require('../common');
+const fixtures = require('../common/fixtures');
+
+// This test ensures that the tls parser causes a client error if the client
+// sends invalid data.
 
 if (!common.hasCrypto)
 common.skip('missing crypto');
@@ -30,11 +34,10 @@ const assert = require('assert');
 const tls = require('tls');
 
 const net = require('net');
-const fs = require('fs');
 
 const options = {
- key: fs.readFileSync(`${common.fixturesDir}/test_key.pem`),
- cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`)
+ key: fixtures.readSync('test_key.pem'),
+ cert: fixtures.readSync('test_cert.pem')
 };
 
 const bonkers = Buffer.alloc(1024 * 1024, 42);

-Original file line number
+Diff line change
 'use strict';
 constcommon=require('../common');
 +constfixtures=require('../common/fixtures');
++
 +// This test ensures that the tls parser causes a client error if the client
 +// sends invalid data.
 if(!common.hasCrypto)
 common.skip('missing crypto');
 consttls=require('tls');
 constnet=require('net');
 -constfs=require('fs');
 constoptions={
 -key: fs.readFileSync(`${common.fixturesDir}/test_key.pem`),
 -cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`)
 +key: fixtures.readSync('test_key.pem'),
 +cert: fixtures.readSync('test_cert.pem')
 };
 constbonkers=Buffer.alloc(1024*1024,42);