lib: enforce use of trailing commas for functions

PR-URL: #46629
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

Author: aduh95

lib/.eslintrc.yaml

@@ -5,7 +5,7 @@ rules:
 comma-dangle: [error, {
 arrays: always-multiline,
 exports: always-multiline,
-functions: only-multiline,
+functions: always-multiline,
 imports: always-multiline,
 objects: only-multiline,
 }]

lib/_http_agent.js

@@ -395,7 +395,7 @@ function installListeners(agent, s, options) {
 // TODO(ronag): Always destroy, even if not in free list.
 constsockets=agent.freeSockets;
 if(ArrayPrototypeSome(ObjectKeys(sockets),(name)=>
-ArrayPrototypeIncludes(sockets[name],s)
+ArrayPrototypeIncludes(sockets[name],s),
 )){
 returns.destroy();
 }

lib/_http_server.js

@@ -604,7 +604,7 @@ function checkConnections() {
 
 functionconnectionListener(socket){
 defaultTriggerAsyncIdScope(
-getOrSetAsyncId(socket),connectionListenerInternal,this,socket
+getOrSetAsyncId(socket),connectionListenerInternal,this,socket,
 );
 }
 
@@ -807,15 +807,15 @@ function onParserTimeout(server, socket) {
 constnoop=()=>{};
 constbadRequestResponse=Buffer.from(
 `HTTP/1.1 400 ${STATUS_CODES[400]}\r\n`+
-'Connection: close\r\n\r\n','ascii'
+'Connection: close\r\n\r\n','ascii',
 );
 constrequestTimeoutResponse=Buffer.from(
 `HTTP/1.1 408 ${STATUS_CODES[408]}\r\n`+
-'Connection: close\r\n\r\n','ascii'
+'Connection: close\r\n\r\n','ascii',
 );
 constrequestHeaderFieldsTooLargeResponse=Buffer.from(
 `HTTP/1.1 431 ${STATUS_CODES[431]}\r\n`+
-'Connection: close\r\n\r\n','ascii'
+'Connection: close\r\n\r\n','ascii',
 );
 functionsocketOnError(e){
 // Ignore further errors

lib/_tls_wrap.js

@@ -171,7 +171,7 @@ function onhandshakedone() {
 functionloadSession(hello){
 debug('server onclienthello',
 'sessionid.len',hello.sessionId.length,
-'ticket?',hello.tlsTicket
+'ticket?',hello.tlsTicket,
 );
 constowner=this[owner_symbol];
 
@@ -350,7 +350,7 @@ function onPskServerCallback(identity, maxPskLen) {
 thrownewERR_INVALID_ARG_TYPE(
 'ret',
 ['Object','Buffer','TypedArray','DataView'],
-ret
+ret,
 );
 }
 psk=ret.psk;
@@ -361,7 +361,7 @@ function onPskServerCallback(identity, maxPskLen) {
 thrownewERR_INVALID_ARG_VALUE(
 'psk',
 psk,
-`Pre-shared key exceeds ${maxPskLen} bytes`
+`Pre-shared key exceeds ${maxPskLen} bytes`,
 );
 }
 
@@ -381,7 +381,7 @@ function onPskClientCallback(hint, maxPskLen, maxIdentityLen) {
 thrownewERR_INVALID_ARG_VALUE(
 'psk',
 ret.psk,
-`Pre-shared key exceeds ${maxPskLen} bytes`
+`Pre-shared key exceeds ${maxPskLen} bytes`,
 );
 }
 
@@ -390,7 +390,7 @@ function onPskClientCallback(hint, maxPskLen, maxIdentityLen) {
 thrownewERR_INVALID_ARG_VALUE(
 'identity',
 ret.identity,
-`PSK identity exceeds ${maxIdentityLen} bytes`
+`PSK identity exceeds ${maxIdentityLen} bytes`,
 );
 }
 
@@ -447,7 +447,7 @@ function initRead(tlsSocket, socket) {
 debug('%s initRead',
 tlsSocket._tlsOptions.isServer ? 'server' : 'client',
 'handle?',!!tlsSocket._handle,
-'buffered?',!!socket&&socket.readableLength
+'buffered?',!!socket&&socket.readableLength,
 );
 // If we were destroyed already don't bother reading
 if(!tlsSocket._handle)
@@ -689,7 +689,7 @@ TLSSocket.prototype._init = function(socket, wrap) {
 
 debug('%s _init',
 options.isServer ? 'server' : 'client',
-'handle?',!!ssl
+'handle?',!!ssl,
 );
 
 // Clients (!isServer) always request a cert, servers request a client cert
@@ -846,7 +846,7 @@ TLSSocket.prototype.renegotiate = function(options, callback) {
 
 debug('%s renegotiate()',
 this._tlsOptions.isServer ? 'server' : 'client',
-'destroyed?',this.destroyed
+'destroyed?',this.destroyed,
 );
 
 if(this.destroyed)
@@ -1456,7 +1456,7 @@ Server.prototype.addContext = function(servername, context) {
 
 constre=newRegExp('^'+StringPrototypeReplaceAll(
 RegExpPrototypeSymbolReplace(/([.^$+?\-\\[\]{}])/g,servername,'\\$1'),
-'*','[^.]*'
+'*','[^.]*',
 )+'$');
 ArrayPrototypePush(this._contexts,
 [re,tls.createSecureContext(context).context]);
@@ -1680,7 +1680,7 @@ exports.connect = function connect(...args) {
 'Setting the TLS ServerName to an IP address is not permitted by '+
 'RFC 6066. This will be ignored in a future version.',
 'DeprecationWarning',
-'DEP0123'
+'DEP0123',
 );
 ipServernameWarned=true;
 }

lib/assert.js

@@ -148,7 +148,7 @@ function fail(actual, expected, message, operator, stackStartFn) {
 'assert.fail() with more than one argument is deprecated. '+
 'Please use assert.strictEqual() instead or only pass a message.',
 'DeprecationWarning',
-'DEP0094'
+'DEP0094',
 );
 }
 if(argsLen===2)
@@ -807,13 +807,13 @@ function expectsError(stackStartFn, actual, error, message) {
 if(actual.message===error){
 thrownewERR_AMBIGUOUS_ARGUMENT(
 'error/message',
-`The error message "${actual.message}" is identical to the message.`
+`The error message "${actual.message}" is identical to the message.`,
 );
 }
 }elseif(actual===error){
 thrownewERR_AMBIGUOUS_ARGUMENT(
 'error/message',
-`The error "${actual}" is identical to the message.`
+`The error "${actual}" is identical to the message.`,
 );
 }
 message=error;
@@ -855,7 +855,7 @@ function hasMatchingError(actual, expected) {
 returnRegExpPrototypeExec(expected,str)!==null;
 }
 thrownewERR_INVALID_ARG_TYPE(
-'expected',['Function','RegExp'],expected
+'expected',['Function','RegExp'],expected,
 );
 }
 // Guard instanceof against arrow functions as they don't have a prototype.
@@ -970,7 +970,7 @@ assert.ifError = function ifError(err) {
 if(origStackStart!==-1){
 constoriginalFrames=StringPrototypeSplit(
 StringPrototypeSlice(origStack,origStackStart+1),
-'\n'
+'\n',
 );
 // Filter all frames existing in err.stack.
 letnewFrames=StringPrototypeSplit(newErr.stack,'\n');
@@ -996,7 +996,7 @@ assert.ifError = function ifError(err) {
 functioninternalMatch(string,regexp,message,fn){
 if(!isRegExp(regexp)){
 thrownewERR_INVALID_ARG_TYPE(
-'regexp','RegExp',regexp
+'regexp','RegExp',regexp,
 );
 }
 constmatch=fn===assert.match;

lib/buffer.js

@@ -335,7 +335,7 @@ Buffer.from = function from(value, encodingOrOffset, length) {
 thrownewERR_INVALID_ARG_TYPE(
 'first argument',
 ['string','Buffer','ArrayBuffer','Array','Array-like Object'],
-value
+value,
 );
 };
 
@@ -745,7 +745,7 @@ function byteLength(string, encoding) {
 }
 
 thrownewERR_INVALID_ARG_TYPE(
-'string',['string','Buffer','ArrayBuffer'],string
+'string',['string','Buffer','ArrayBuffer'],string,
 );
 }
 
@@ -966,7 +966,7 @@ function bidirectionalIndexOf(buffer, val, byteOffset, encoding, dir) {
 }
 
 thrownewERR_INVALID_ARG_TYPE(
-'value',['number','string','Buffer','Uint8Array'],val
+'value',['number','string','Buffer','Uint8Array'],val,
 );
 }
 
@@ -1222,7 +1222,7 @@ if (internalBinding('config').hasIntl) {
 constcode=icuErrName(result);
 consterr=genericNodeError(
 `Unable to transcode Buffer [${code}]`,
-{code: code,errno: result}
+{code: code,errno: result},
 );
 throwerr;
 };

lib/child_process.js

@@ -56,7 +56,7 @@ let debug = require('internal/util/debuglog').debuglog(
 'child_process',
 (fn)=>{
 debug=fn;
-}
+},
 );
 const{ Buffer }=require('buffer');
 const{ Pipe,constants: PipeConstants}=internalBinding('pipe_wrap');
@@ -686,7 +686,7 @@ function normalizeSpawnArguments(file, args, options) {
 }
 sawKey.add(uppercaseKey);
 returntrue;
-}
+},
 );
 }
 

lib/crypto.js

@@ -307,7 +307,7 @@ function getRandomBytesAlias(key) {
 configurable: true,
 writable: true,
 value: value
-}
+},
 );
 returnvalue;
 },
@@ -321,7 +321,7 @@ function getRandomBytesAlias(key) {
 configurable: true,
 writable: true,
  value
-}
+},
 );
 }
 };

lib/dgram.js

@@ -412,7 +412,7 @@ function _connect(port, address, callback) {
 defaultTriggerAsyncIdScope(
 this[async_id_symbol],
 doConnect,
-ex,this,ip,address,port,callback
+ex,this,ip,address,port,callback,
 );
 };
 
@@ -662,7 +662,7 @@ Socket.prototype.send = function(buffer,
 defaultTriggerAsyncIdScope(
 this[async_id_symbol],
 doSend,
-ex,this,ip,list,address,port,callback
+ex,this,ip,list,address,port,callback,
 );
 };
 
@@ -1066,7 +1066,7 @@ module.exports = {
 _createSocketHandle: deprecate(
 _createSocketHandle,
 'dgram._createSocketHandle() is deprecated',
-'DEP0112'
+'DEP0112',
 ),
  createSocket,
  Socket

lib/dns.js

@@ -219,7 +219,7 @@ function lookup(hostname, options, callback) {
 req.oncomplete=all ? onlookupall : onlookup;
 
 consterr=cares.getaddrinfo(
-req,toASCII(hostname),family,hints,verbatim
+req,toASCII(hostname),family,hints,verbatim,
 );
 if(err){
 process.nextTick(callback,dnsException(err,'getaddrinfo',hostname));