tls: avoid external memory leak on invalid protocol versions

codebytere · aduh95 · commit 377e8ce85ac2 · 2025-10-26T22:30:23.000+01:00
PR-URL: #60390 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/tls/common.js b/lib/internal/tls/common.js
@@ -82,10 +82,11 @@ function SecureContext(secureProtocol, secureOptions, minVersion, maxVersion) {
 throw new ERR_TLS_PROTOCOL_VERSION_CONFLICT(maxVersion, secureProtocol);
 }
 
+ const minV = toV('minimum', minVersion, tls.DEFAULT_MIN_VERSION);
+ const maxV = toV('maximum', maxVersion, tls.DEFAULT_MAX_VERSION);
+
 this.context = new NativeSecureContext();
- this.context.init(secureProtocol,
- toV('minimum', minVersion, tls.DEFAULT_MIN_VERSION),
- toV('maximum', maxVersion, tls.DEFAULT_MAX_VERSION));
+ this.context.init(secureProtocol, minV, maxV);
 
 if (secureOptions) {
 validateInteger(secureOptions, 'secureOptions');

-Original file line number
+Diff line change
 thrownewERR_TLS_PROTOCOL_VERSION_CONFLICT(maxVersion,secureProtocol);
+}
 +constminV=toV('minimum',minVersion,tls.DEFAULT_MIN_VERSION);
 +constmaxV=toV('maximum',maxVersion,tls.DEFAULT_MAX_VERSION);
++
 this.context=newNativeSecureContext();
 -this.context.init(secureProtocol,
 -toV('minimum',minVersion,tls.DEFAULT_MIN_VERSION),
 -toV('maximum',maxVersion,tls.DEFAULT_MAX_VERSION));
 +this.context.init(secureProtocol,minV,maxV);
 if(secureOptions){
 validateInteger(secureOptions,'secureOptions');