http: onFinish will not be triggered again when finished

PR-URL: #35845Fixes: #35833
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: rickyes

lib/_http_outgoing.js

@@ -814,6 +814,12 @@ OutgoingMessage.prototype.end = function end(chunk, encoding, callback) {
 }
 
 if(chunk){
+if(this.finished){
+onError(this,
+newERR_STREAM_WRITE_AFTER_END(),
+typeofcallback!=='function' ? nop : callback);
+returnthis;
+}
 write_(this,chunk,encoding,null,true);
 }elseif(this.finished){
 if(typeofcallback==='function'){

test/parallel/test-http-outgoing-end-multiple.js

@@ -3,9 +3,17 @@ const common = require('../common');
 constassert=require('assert');
 consthttp=require('http');
 
+constonWriteAfterEndError=common.mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_STREAM_WRITE_AFTER_END');
+},2);
+
 constserver=http.createServer(common.mustCall(function(req,res){
 res.end('testing ended state',common.mustCall());
-res.end(common.mustCall());
+res.end(common.mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_STREAM_ALREADY_FINISHED');
+}));
+res.end('end',onWriteAfterEndError);
+res.on('error',onWriteAfterEndError);
 res.on('finish',common.mustCall(()=>{
 res.end(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ERR_STREAM_ALREADY_FINISHED');