http: throw error if options of http.Server is array

If options of http.Server is array, throw ERR_INVALID_ARG_TYPE.
Refs: #24176
PR-URL: #46283
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: deokjinkim

lib/_http_server.js

@@ -75,10 +75,12 @@ const {
 ERR_HTTP_HEADERS_SENT,
 ERR_HTTP_INVALID_STATUS_CODE,
 ERR_HTTP_SOCKET_ENCODING,
-ERR_INVALID_ARG_TYPE,
 ERR_INVALID_ARG_VALUE,
 ERR_INVALID_CHAR
 }=codes;
+const{
+ kEmptyObject,
+}=require('internal/util');
 const{
  validateInteger,
  validateBoolean,
@@ -433,9 +435,6 @@ function storeHTTPOptions(options) {
 validateBoolean(insecureHTTPParser,'options.insecureHTTPParser');
 this.insecureHTTPParser=insecureHTTPParser;
 
-if(options.noDelay===undefined)
-options.noDelay=true;
-
 constrequestTimeout=options.requestTimeout;
 if(requestTimeout!==undefined){
 validateInteger(requestTimeout,'requestTimeout',0);
@@ -502,17 +501,17 @@ function Server(options, requestListener) {
 
 if(typeofoptions==='function'){
 requestListener=options;
-options={};
-}elseif(options==null||typeofoptions==='object'){
-options={ ...options};
+options=kEmptyObject;
+}elseif(options==null){
+options=kEmptyObject;
 }else{
-thrownewERR_INVALID_ARG_TYPE('options','object',options);
+validateObject(options,'options');
 }
 
 storeHTTPOptions.call(this,options);
 net.Server.call(
 this,
-{allowHalfOpen: true,noDelay: options.noDelay,
+{allowHalfOpen: true,noDelay: options.noDelay??true,
 keepAlive: options.keepAlive,
 keepAliveInitialDelay: options.keepAliveInitialDelay});
 

lib/https.js

@@ -53,25 +53,31 @@ let debug = require('internal/util/debuglog').debuglog('https', (fn) => {
 debug=fn;
 });
 const{URL, urlToHttpOptions, searchParamsSymbol }=require('internal/url');
+const{ validateObject }=require('internal/validators');
 
 functionServer(opts,requestListener){
 if(!(thisinstanceofServer))returnnewServer(opts,requestListener);
 
 if(typeofopts==='function'){
 requestListener=opts;
-opts=undefined;
-}
-opts={ ...opts};
-
-if(!opts.ALPNProtocols){
-// http/1.0 is not defined as Protocol IDs in IANA
-// https://www.iana.org/assignments/tls-extensiontype-values
-// /tls-extensiontype-values.xhtml#alpn-protocol-ids
-opts.ALPNProtocols=['http/1.1'];
+opts=kEmptyObject;
+}elseif(opts==null){
+opts=kEmptyObject;
+}else{
+validateObject(opts,'options');
 }
 
 FunctionPrototypeCall(storeHTTPOptions,this,opts);
-FunctionPrototypeCall(tls.Server,this,opts,_connectionListener);
+FunctionPrototypeCall(tls.Server,this,
+{
+noDelay: true,
+// http/1.0 is not defined as Protocol IDs in IANA
+// https://www.iana.org/assignments/tls-extensiontype-values
+// /tls-extensiontype-values.xhtml#alpn-protocol-ids
+ALPNProtocols: ['http/1.1'],
+ ...opts,
+},
+_connectionListener);
 
 this.httpAllowHalfOpen=false;
 

test/parallel/test-http-server.js

@@ -27,10 +27,7 @@ const http = require('http');
 consturl=require('url');
 constqs=require('querystring');
 
-// TODO: documentation does not allow Array as an option, so testing that
-// should fail, but currently http.Server does not typecheck further than
-// if `option` is `typeof object` - so we don't test that here right now
-constinvalid_options=['foo',42,true];
+constinvalid_options=['foo',42,true,[]];
 
 invalid_options.forEach((option)=>{
 assert.throws(()=>{

test/parallel/test-https-simple.js

@@ -44,6 +44,15 @@ const serverCallback = common.mustCall(function(req, res) {
 res.end(body);
 });
 
+constinvalid_options=['foo',42,true,[]];
+invalid_options.forEach((option)=>{
+assert.throws(()=>{
+newhttps.Server(option);
+},{
+code: 'ERR_INVALID_ARG_TYPE',
+});
+});
+
 constserver=https.createServer(options,serverCallback);
 
 server.listen(0,common.mustCall(()=>{