lib: combine contructor, tag, Object into a function

Paul-Isache · MylesBorins · commit 3966b698f669 · 2018-12-26T11:18:53.000-05:00
combine these parts into a function to be used in multiple parts PR-URL: #24171 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -362,6 +362,10 @@ function getKeys(value, showHidden) {
 return keys;
 }
 
+function getCtxStyle(constructor, tag) {
+ return constructor || tag || 'Object';
+}
+
 function formatProxy(ctx, proxy, recurseTimes) {
 if (recurseTimes != null) {
 if (recurseTimes < 0)
@@ -708,7 +712,7 @@ function formatRaw(ctx, value, recurseTimes) {
 
 if (recurseTimes != null) {
 if (recurseTimes < 0)
- return ctx.stylize(`[${constructor || tag || 'Object'}]`, 'special');
+ return ctx.stylize(`[${getCtxStyle(constructor, tag)}]`, 'special');
 recurseTimes -= 1;
 }
 
@@ -746,7 +750,7 @@ function handleMaxCallStackSize(ctx, err, constructor, tag, indentationLvl) {
 ctx.seen.pop();
 ctx.indentationLvl = indentationLvl;
 return ctx.stylize(
- `[${constructor || tag || 'Object'}: Inspection interrupted ` +
+ `[${getCtxStyle(constructor, tag)}: Inspection interrupted ` +
 'prematurely. Maximum call stack size exceeded.]',
 'special'
 );

-Original file line number
+Diff line change
 returnkeys;
+}
 +functiongetCtxStyle(constructor,tag){
 +returnconstructor||tag||'Object';
 +}
++
 functionformatProxy(ctx,proxy,recurseTimes){
 if(recurseTimes!=null){
 if(recurseTimes<0)
 if(recurseTimes!=null){
 if(recurseTimes<0)
 -returnctx.stylize(`[${constructor||tag||'Object'}]`,'special');
 +returnctx.stylize(`[${getCtxStyle(constructor,tag)}]`,'special');
 recurseTimes-=1;
+}
 ctx.seen.pop();
 ctx.indentationLvl=indentationLvl;
 returnctx.stylize(
 -`[${constructor||tag||'Object'}: Inspection interrupted `+
 +`[${getCtxStyle(constructor,tag)}: Inspection interrupted `+
 'prematurely. Maximum call stack size exceeded.]',
 'special'
 );