src: use new V8 API to define stream accessor

Define XxxStream.prototype.onread as an accessor in JavaScript sense.
Previously it was defined via soon-to-be-deprecated
`v8::ObjectTemplate::SetAccessor(..)` which used to call setter even
for property stores via stream object.
The replacement V8 API `v8::ObjectTemplate::SetNativeDataProperty(..)`
defines a properly behaving data property and thus a store to a stream
object will not trigger the "onread" setter callback.
In order to preserve the desired behavior of storing the value in the
receiver's internal field the "onread" property should be defined as
a proper JavaScript accessor.
PR-URL: #53084
Refs: v8/v8@46c241e
Refs: v8/v8@6ec8839
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: isheludko

src/base_object-inl.h

@@ -132,19 +132,18 @@ v8::EmbedderGraph::Node::Detachedness BaseObject::GetDetachedness() const {
 
 template <int Field>
 voidBaseObject::InternalFieldGet(
- v8::Local<v8::Name> property,
-const v8::PropertyCallbackInfo<v8::Value>& info) {
- info.GetReturnValue().Set(
- info.This()->GetInternalField(Field).As<v8::Value>());
+const v8::FunctionCallbackInfo<v8::Value>& args) {
+ args.GetReturnValue().Set(
+ args.This()->GetInternalField(Field).As<v8::Value>());
 }
 
 template <int Field, bool (v8::Value::*typecheck)() const>
-voidBaseObject::InternalFieldSet(v8::Local<v8::Name> property,
-v8::Local<v8::Value> value,
-constv8::PropertyCallbackInfo<void>& info) {
+voidBaseObject::InternalFieldSet(
+constv8::FunctionCallbackInfo<v8::Value>& args) {
+ v8::Local<v8::Value> value = args[0];
 // This could be e.g. value->IsFunction().
 CHECK(((*value)->*typecheck)());
-info.This()->SetInternalField(Field, value);
+args.This()->SetInternalField(Field, value);
 }
 
 boolBaseObject::has_pointer_data() const {

src/base_object.h

@@ -111,12 +111,9 @@ class BaseObject : public MemoryRetainer {
 
 // Setter/Getter pair for internal fields that can be passed to SetAccessor.
 template <int Field>
-staticvoidInternalFieldGet(v8::Local<v8::Name> property,
-const v8::PropertyCallbackInfo<v8::Value>& info);
+staticvoidInternalFieldGet(const v8::FunctionCallbackInfo<v8::Value>& args);
 template <int Field, bool (v8::Value::*typecheck)() const>
-staticvoidInternalFieldSet(v8::Local<v8::Name> property,
- v8::Local<v8::Value> value,
-const v8::PropertyCallbackInfo<void>& info);
+staticvoidInternalFieldSet(const v8::FunctionCallbackInfo<v8::Value>& args);
 
 // This is a bit of a hack. See the override in async_wrap.cc for details.
 virtualboolIsDoneInitializing() const;

src/stream_base.cc

@@ -492,6 +492,29 @@ Local<Object> StreamBase::GetObject() {
 returnGetAsyncWrap()->object();
 }
 
+voidStreamBase::AddAccessor(v8::Isolate* isolate,
+ v8::Local<v8::Signature> signature,
+enum v8::PropertyAttribute attributes,
+ v8::Local<v8::FunctionTemplate> t,
+ JSMethodFunction* getter,
+ JSMethodFunction* setter,
+ v8::Local<v8::String> string) {
+ Local<FunctionTemplate> getter_templ =
+NewFunctionTemplate(isolate,
+ getter,
+ signature,
+ ConstructorBehavior::kThrow,
+ SideEffectType::kHasNoSideEffect);
+ Local<FunctionTemplate> setter_templ =
+NewFunctionTemplate(isolate,
+ setter,
+ signature,
+ ConstructorBehavior::kThrow,
+ SideEffectType::kHasSideEffect);
+ t->PrototypeTemplate()->SetAccessorProperty(
+ string, getter_templ, setter_templ, attributes);
+}
+
 voidStreamBase::AddMethod(Isolate* isolate,
  Local<Signature> signature,
 enum PropertyAttribute attributes,
@@ -561,11 +584,14 @@ void StreamBase::AddMethods(IsolateData* isolate_data,
  JSMethod<&StreamBase::WriteString<LATIN1>>);
  t->PrototypeTemplate()->Set(FIXED_ONE_BYTE_STRING(isolate, "isStreamBase"),
 True(isolate));
- t->PrototypeTemplate()->SetAccessor(
-FIXED_ONE_BYTE_STRING(isolate, "onread"),
- BaseObject::InternalFieldGet<StreamBase::kOnReadFunctionField>,
- BaseObject::InternalFieldSet<StreamBase::kOnReadFunctionField,
- &Value::IsFunction>);
+AddAccessor(isolate,
+ sig,
+static_cast<PropertyAttribute>(DontDelete | DontEnum),
+ t,
+ BaseObject::InternalFieldGet<StreamBase::kOnReadFunctionField>,
+ BaseObject::InternalFieldSet<StreamBase::kOnReadFunctionField,
+ &Value::IsFunction>,
+FIXED_ONE_BYTE_STRING(isolate, "onread"));
 }
 
 voidStreamBase::RegisterExternalReferences(

src/stream_base.h

@@ -413,6 +413,13 @@ class StreamBase : public StreamResource {
  EmitToJSStreamListener default_listener_;
 
 voidSetWriteResult(const StreamWriteResult& res);
+staticvoidAddAccessor(v8::Isolate* isolate,
+ v8::Local<v8::Signature> sig,
+enum v8::PropertyAttribute attributes,
+ v8::Local<v8::FunctionTemplate> t,
+ JSMethodFunction* getter,
+ JSMethodFunction* setter,
+ v8::Local<v8::String> str);
 staticvoidAddMethod(v8::Isolate* isolate,
  v8::Local<v8::Signature> sig,
 enum v8::PropertyAttribute attributes,