test: ensure assertions are reached on HTTP tests

PR-URL: #60729
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: aduh95

test/eslint.config_partial.mjs

@@ -195,7 +195,7 @@ export default [
 `test/parallel/test-{${
 // 0x61 is code for 'a', this generates a string enumerating latin letters: 'a*,b*,…'
 Array.from({length: 4},(_,i)=>String.fromCharCode(0x61+i,42)).join(',')
-},${
+},http-*,${
 // 0x61 is code for 'a', this generates a string enumerating latin letters: 'z*,y*,…'
 Array.from({length: 5},(_,i)=>String.fromCharCode(0x61+25-i,42)).join(',')
 }}.{js,mjs,cjs}`,

test/parallel/test-http-1.0.js

@@ -34,7 +34,7 @@ function test(handler, request_generator, response_validator) {
 letserver_response='';
 
 server.listen(0);
-server.on('listening',function(){
+server.on('listening',common.mustCall(function(){
 constc=net.createConnection(this.address().port);
 
 c.setEncoding('utf8');
@@ -53,7 +53,7 @@ function test(handler, request_generator, response_validator) {
 server.close();
 response_validator(server_response,client_got_eof,false);
 }));
-});
+}));
 }
 
 {

test/parallel/test-http-abort-queued.js

@@ -52,7 +52,7 @@ server.listen(0, common.mustCall(() => {
 };
 
 constreq1=http.request(options);
-req1.on('response',(res1)=>{
+req1.on('response',common.mustCall((res1)=>{
 assert.strictEqual(Object.keys(agent.sockets).length,1);
 assert.strictEqual(Object.keys(agent.requests).length,0);
 
@@ -68,10 +68,10 @@ server.listen(0, common.mustCall(() => {
 
 // TODO(jasnell): This event does not appear to currently be triggered.
 // is this handler actually required?
-req2.on('error',(err)=>{
+req2.on('error',common.mustCallAtLeast((err)=>{
 // This is expected in response to our explicit abort call
 assert.strictEqual(err.code,'ECONNRESET');
-});
+},0));
 
 req2.end();
 req2.abort();
@@ -89,7 +89,7 @@ server.listen(0, common.mustCall(() => {
 server.close();
 }),100);
 }));
-});
+}));
 
 req1.end();
 }));

test/parallel/test-http-abort-stream-end.js

@@ -38,21 +38,21 @@ const server = http.createServer(common.mustCall((req, res) => {
 res.end();
 }));
 
-server.listen(0,()=>{
+server.listen(0,common.mustCall(()=>{
 constres=common.mustCall((res)=>{
-res.on('data',(chunk)=>{
+res.on('data',common.mustCallAtLeast((chunk)=>{
 size+=chunk.length;
 assert(!req.aborted,'got data after abort');
 if(size>maxSize){
 req.abort();
 assert.strictEqual(req.aborted,true);
 size=maxSize;
 }
-});
+}));
 
 req.on('abort',common.mustCall(()=>assert.strictEqual(size,maxSize)));
 assert.strictEqual(req.aborted,false);
 });
 
 constreq=http.get(`http://localhost:${server.address().port}`,res);
-});
+}));

test/parallel/test-http-agent-error-on-idle.js

@@ -9,7 +9,7 @@ const server = http.createServer(common.mustCall((req, res) => {
 res.end('hello world');
 },2));
 
-server.listen(0,()=>{
+server.listen(0,common.mustCall(()=>{
 constagent=newAgent({keepAlive: true});
 
 constrequestParams={
@@ -46,4 +46,4 @@ server.listen(0, () => {
 agent.destroy();
 server.close();
 }
-});
+}));

test/parallel/test-http-agent-keepalive-delay.js

@@ -16,11 +16,11 @@ const server = http.createServer(common.mustCall((req, res) => {
 
 server.listen(0,common.mustCall(()=>{
 constcreateConnection=agent.createConnection;
-agent.createConnection=(options, ...args)=>{
+agent.createConnection=common.mustCall((options, ...args)=>{
 assert.strictEqual(options.keepAlive,true);
 assert.strictEqual(options.keepAliveInitialDelay,agent.keepAliveMsecs);
 returncreateConnection.call(agent,options, ...args);
-};
+});
 http.get({
 host: 'localhost',
 port: server.address().port,

test/parallel/test-http-agent-maxsockets.js

@@ -26,13 +26,13 @@ function get(path, callback) {
 },callback);
 }
 
-constcountdown=newCountdown(2,()=>{
+constcountdown=newCountdown(2,common.mustCall(()=>{
 constfreepool=agent.freeSockets[Object.keys(agent.freeSockets)[0]];
 assert.strictEqual(freepool.length,2,
 `expect keep 2 free sockets, but got ${freepool.length}`);
 agent.destroy();
 server.close();
-});
+}));
 
 functiondec(){
 process.nextTick(()=>countdown.dec());

test/parallel/test-http-agent-maxtotalsockets.js

@@ -48,12 +48,12 @@ function start(param = {}) {
 server.keepAliveTimeout=0;
 server2.keepAliveTimeout=0;
 
-constcountdown=newCountdown(12,()=>{
+constcountdown=newCountdown(12,common.mustCall(()=>{
 assert.strictEqual(getRequestCount(),0);
 agent.destroy();
 server.close();
 server2.close();
-});
+}));
 
 functionhandler(s){
 for(leti=0;i<6;i++){

test/parallel/test-http-agent-remove.js

@@ -2,7 +2,7 @@
 const{ mustCall }=require('../common');
 
 consthttp=require('http');
-const{ strictEqual }=require('assert');
+constassert=require('assert');
 
 constserver=http.createServer(mustCall((req,res)=>{
 res.flushHeaders();
@@ -14,7 +14,7 @@ server.listen(0, mustCall(() => {
 },mustCall(()=>{
 const{ socket }=req;
 socket.emit('agentRemove');
-strictEqual(socket._httpMessage,req);
+assert.strictEqual(socket._httpMessage,req);
 socket.destroy();
 server.close();
 }));

test/parallel/test-http-agent-reuse-drained-socket-only.js

@@ -28,14 +28,14 @@ function sendFstReq(serverPort) {
  agent,
 host: '127.0.0.1',
 port: serverPort,
-},(res)=>{
+},common.mustCall((res)=>{
 res.on('data',noop);
 res.on('end',common.mustCall(()=>{
 // Agent's socket reusing code is registered to process.nextTick(),
 // and will be run after this function, make sure it take effect.
 setImmediate(sendSecReq,serverPort,req.socket.localPort);
 }));
-});
+}));
 
 // Make the `req.socket` non drained, i.e. has some data queued to write to
 // and accept by the kernel. In Linux and Mac, we only need to call `req.end(aLargeBuffer)`.
@@ -60,8 +60,8 @@ function sendFstReq(serverPort) {
  * back the socket within SO_SNDBUF quota or only one outstanding send condition.
  */
 
-req.on('socket',()=>{
-req.socket.on('connect',()=>{
+req.on('socket',common.mustCall(()=>{
+req.socket.on('connect',common.mustCall(()=>{
 // Print tcp send buffer information
 console.log(process.report.getReport().libuv.filter((handle)=>handle.type==='tcp'));
 
@@ -81,8 +81,8 @@ function sendFstReq(serverPort) {
 
 req.end(dataLargerThanTCPSendBuf);
 assert.ok(req.socket.writableLength>0);
-});
-});
+}));
+}));
 }
 
 functionsendSecReq(serverPort,fstReqCliPort){
@@ -92,12 +92,12 @@ function sendSecReq(serverPort, fstReqCliPort) {
  agent,
 host: '127.0.0.1',
 port: serverPort,
-},(res)=>{
+},common.mustCall((res)=>{
 res.on('data',noop);
 res.on('end',common.mustCall(()=>{
 setImmediate(sendThrReq,serverPort,req.socket.localPort);
 }));
-});
+}));
 
 req.on('socket',common.mustCall((sock)=>{
 assert.notStrictEqual(sock.localPort,fstReqCliPort);