test_runner: don't parse TAP from stderr

This commit stops the test runner CLI from parsing child
process stderr as TAP. Per the TAP spec, TAP can only come from
stdout. To avoid losing stderr data, those logs are injected
into the parser as unknown tokens so that they are output as
comments.
PR-URL: #45618
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Author: cjihrig

lib/internal/test_runner/runner.js

@@ -241,22 +241,29 @@ function runTestFile(path, root, inspectPort, filesWatcher) {
 err=error;
 });
 
-if(isUsingInspector()){
-constrl=createInterface({input: child.stderr});
-rl.on('line',(line)=>{
-if(isInspectorMessage(line)){
-process.stderr.write(line+'\n');
-}
-});
-}
-
-constparser=newTapParser();
-child.stderr.pipe(parser).on('data',(ast)=>{
-if(ast.lexeme&&isInspectorMessage(ast.lexeme)){
-process.stderr.write(ast.lexeme+'\n');
+constrl=createInterface({input: child.stderr});
+rl.on('line',(line)=>{
+if(isInspectorMessage(line)){
+process.stderr.write(line+'\n');
+return;
 }
+
+// stderr cannot be treated as TAP, per the spec. However, we want to
+// surface stderr lines as TAP diagnostics to improve the DX. Inject
+// each line into the test output as an unknown token as if it came
+// from the TAP parser.
+constnode={
+kind: TokenKind.UNKNOWN,
+node: {
+value: line,
+},
+};
+
+subtest.addToReport(node);
 });
 
+constparser=newTapParser();
+
 child.stdout.pipe(parser).on('data',(ast)=>{
 subtest.addToReport(ast);
 });

lib/internal/util/inspector.js

@@ -16,7 +16,7 @@ const { validatePort } = require('internal/validators');
 constkMinPort=1024;
 constkMaxPort=65535;
 constkInspectArgRegex=/--inspect(?:-brk|-port)?|--debug-port/;
-constkInspectMsgRegex=/Debuggerlisteningonws:\/\/\[?(.+?)\]?:(\d+)\/|Debuggerattached|Waitingforthedebuggertodisconnect\.\.\./;
+constkInspectMsgRegex=/Debuggerlisteningonws:\/\/\[?(.+?)\]?:(\d+)\/|Forhelp,see:https:\/\/nodejs\.org\/en\/docs\/inspector|Debuggerattached|Waitingforthedebuggertodisconnect\.\.\./;
 
 const_isUsingInspector=newSafeWeakMap();
 functionisUsingInspector(execArgv=process.execArgv){

test/fixtures/test-runner/user-logs.js

@@ -0,0 +1,20 @@
+'use strict';
+consttest=require('node:test');
+
+console.error('stderr',1);
+
+test('a test',async()=>{
+console.error('stderr',2);
+awaitnewPromise((resolve)=>{
+console.log('stdout',3);
+setTimeout(()=>{
+// This should not be sent to the TAP parser.
+console.error('not ok 1 - fake test');
+resolve();
+console.log('stdout',4);
+},2);
+});
+console.error('stderr',5);
+});
+
+console.error('stderr',6);

test/parallel/test-runner-cli.js

@@ -168,3 +168,29 @@ const testFixtures = fixtures.path('test-runner');
 assert.match(stdout,/#pass2/);
 assert.match(stdout,/#fail1/);
 }
+
+{
+// Test user logging in tests.
+constargs=[
+'--test',
+'test/fixtures/test-runner/user-logs.js',
+];
+constchild=spawnSync(process.execPath,args);
+
+assert.strictEqual(child.status,0);
+assert.strictEqual(child.signal,null);
+assert.strictEqual(child.stderr.toString(),'');
+conststdout=child.stdout.toString();
+assert.match(stdout,/#Subtest:.+user-logs\.js/);
+assert.match(stdout,/{4}#stderr1/);
+assert.match(stdout,/{4}#stderr2/);
+assert.match(stdout,/{4}#stdout3/);
+assert.match(stdout,/{4}#stderr6/);
+assert.match(stdout,/{4}#notok1-faketest/);
+assert.match(stdout,/{4}#stderr5/);
+assert.match(stdout,/{4}#stdout4/);
+assert.match(stdout,/{4}#Subtest:atest/);
+assert.match(stdout,/{4}ok1-atest/);
+assert.match(stdout,/#tests1/);
+assert.match(stdout,/#pass1/);
+}