benchmark,doc,lib,test: prepare for padding lint rule

Trott · targos · commit 3e588713cca2 · 2019-12-05T13:54:36.000+01:00
Upcoming lint rule will require a blank line between consecutive functions. Add it in the places where we don't have it already. PR-URL: #30696 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/benchmark/process/next-tick-breadth-args.js b/benchmark/process/next-tick-breadth-args.js
@@ -13,16 +13,19 @@ function main({ n }) {
 if (j === n)
 bench.end(n);
 }
+
 function cb2(arg1, arg2) {
 j++;
 if (j === n)
 bench.end(n);
 }
+
 function cb3(arg1, arg2, arg3) {
 j++;
 if (j === n)
 bench.end(n);
 }
+
 function cb4(arg1, arg2, arg3, arg4) {
 j++;
 if (j === n)
diff --git a/benchmark/process/next-tick-depth-args.js b/benchmark/process/next-tick-depth-args.js
@@ -20,6 +20,7 @@ function main({ n }) {
 } else
 bench.end(n);
 }
+
 function cb3(arg1, arg2, arg3) {
 if (--counter) {
 if (counter % 4 === 0)
@@ -33,6 +34,7 @@ function main({ n }) {
 } else
 bench.end(n);
 }
+
 function cb2(arg1, arg2) {
 if (--counter) {
 if (counter % 4 === 0)
@@ -46,6 +48,7 @@ function main({ n }) {
 } else
 bench.end(n);
 }
+
 function cb1(arg1) {
 if (--counter) {
 if (counter % 4 === 0)
diff --git a/benchmark/timers/set-immediate-breadth-args.js b/benchmark/timers/set-immediate-breadth-args.js
@@ -12,7 +12,9 @@ function main({ n }) {
 });
 
 function cb1(arg1) {}
+
 function cb2(arg1, arg2) {}
+
 function cb3(arg1, arg2, arg3) {}
 
 bench.start();
diff --git a/benchmark/timers/set-immediate-depth-args.js b/benchmark/timers/set-immediate-depth-args.js
@@ -21,6 +21,7 @@ function main({ n }) {
 setImmediate(cb1, n);
 }
 }
+
 function cb2(n, arg2) {
 if (--n) {
 if (n % 3 === 0)
@@ -31,6 +32,7 @@ function main({ n }) {
 setImmediate(cb1, n);
 }
 }
+
 function cb1(n) {
 if (--n) {
 if (n % 3 === 0)
diff --git a/benchmark/timers/timers-breadth-args.js b/benchmark/timers/timers-breadth-args.js
@@ -12,16 +12,19 @@ function main({ n }) {
 if (j === n)
 bench.end(n);
 }
+
 function cb2(arg1, arg2) {
 j++;
 if (j === n)
 bench.end(n);
 }
+
 function cb3(arg1, arg2, arg3) {
 j++;
 if (j === n)
 bench.end(n);
 }
+
 function cb4(arg1, arg2, arg3, arg4) {
 j++;
 if (j === n)
diff --git a/benchmark/timers/timers-timeout-nexttick.js b/benchmark/timers/timers-timeout-nexttick.js
@@ -19,9 +19,11 @@ function main({ n }) {
 function cb() {
 process.nextTick(counter);
 }
+
 function cb2() {
 process.nextTick(counter);
 }
+
 function counter() {
 count++;
 if (count === n)
diff --git a/benchmark/timers/timers-timeout-pooled.js b/benchmark/timers/timers-timeout-pooled.js
@@ -20,6 +20,7 @@ function main({ n }) {
 if (count === n)
 bench.end(n);
 }
+
 function cb2() {
 count++;
 if (count === n)
diff --git a/benchmark/timers/timers-timeout-unpooled.js b/benchmark/timers/timers-timeout-unpooled.js
@@ -20,6 +20,7 @@ function main({ n }) {
 if (count === n)
 bench.end(n);
 }
+
 function cb2() {
 count++;
 if (count === n)
diff --git a/doc/api/assert.md b/doc/api/assert.md
@@ -1256,9 +1256,11 @@ a string as the second argument gets considered:
 function throwingFirst() {
 throw new Error('First');
 }
+
 function throwingSecond() {
 throw new Error('Second');
 }
+
 function notThrowing() {}
 
 // The second argument is a string and the input function threw an Error.
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -623,6 +623,7 @@ function needFinish(state) {
 !state.finished &&
 !state.writing);
 }
+
 function callFinal(stream, state) {
 stream._final((err) => {
 state.pendingcb--;
@@ -634,6 +635,7 @@ function callFinal(stream, state) {
 finishMaybe(stream, state);
 });
 }
+
 function prefinish(stream, state) {
 if (!state.prefinished && !state.finalCalled) {
 if (typeof stream._final === 'function' && !state.destroyed) {
diff --git a/lib/internal/assert.js b/lib/internal/assert.js
@@ -7,6 +7,7 @@ function lazyError() {
 }
 return error;
 }
+
 function assert(value, message) {
 if (!value) {
 const ERR_INTERNAL_ASSERTION = lazyError();
diff --git a/lib/internal/js_stream_socket.js b/lib/internal/js_stream_socket.js
@@ -14,9 +14,13 @@ const kCurrentShutdownRequest = Symbol('kCurrentShutdownRequest');
 const kPendingShutdownRequest = Symbol('kPendingShutdownRequest');
 
 function isClosing() { return this[owner_symbol].isClosing(); }
+
 function onreadstart() { return this[owner_symbol].readStart(); }
+
 function onreadstop() { return this[owner_symbol].readStop(); }
+
 function onshutdown(req) { return this[owner_symbol].doShutdown(req); }
+
 function onwrite(req, bufs) { return this[owner_symbol].doWrite(req, bufs); }
 
 /* This class serves as a wrapper for when the C++ side of Node wants access
diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js
@@ -46,6 +46,7 @@ const kHasTickScheduled = 0;
 function hasTickScheduled() {
 return tickInfo[kHasTickScheduled] === 1;
 }
+
 function setHasTickScheduled(value) {
 tickInfo[kHasTickScheduled] = value ? 1 : 0;
 }
diff --git a/lib/internal/process/worker_thread_only.js b/lib/internal/process/worker_thread_only.js
@@ -16,6 +16,7 @@ function lazyWorkerStdio() {
 if (!workerStdio) workerStdio = createWorkerStdio();
 return workerStdio;
 }
+
 function createStdioGetters() {
 return {
 getStdout() { return lazyWorkerStdio().stdout; },
diff --git a/lib/repl.js b/lib/repl.js
@@ -259,6 +259,7 @@ function REPLServer(prompt,
 function pause() {
 paused = true;
 }
+
 function unpause() {
 if (!paused) return;
 paused = false;
diff --git a/test/es-module/test-esm-data-urls.js b/test/es-module/test-esm-data-urls.js
@@ -5,6 +5,7 @@ const assert = require('assert');
 function createURL(mime, body) {
 return `data:${mime},${body}`;
 }
+
 function createBase64URL(mime, body) {
 return `data:${mime};base64,${Buffer.from(body).toString('base64')}`;
 }
diff --git a/test/parallel/test-event-emitter-listeners.js b/test/parallel/test-event-emitter-listeners.js
@@ -26,10 +26,13 @@ const assert = require('assert');
 const events = require('events');
 
 function listener() {}
+
 function listener2() {}
+
 function listener3() {
 return 0;
 }
+
 function listener4() {
 return 1;
 }
diff --git a/test/parallel/test-event-emitter-remove-listeners.js b/test/parallel/test-event-emitter-remove-listeners.js
@@ -25,6 +25,7 @@ const assert = require('assert');
 const EventEmitter = require('events');
 
 function listener1() {}
+
 function listener2() {}
 
 {
diff --git a/test/parallel/test-fs-realpath.js b/test/parallel/test-fs-realpath.js
@@ -490,6 +490,7 @@ function test_abs_with_kids(realpath, realpathSync, cb) {
 try { fs.rmdirSync(root + folder); } catch {}
 });
 }
+
 function setup() {
 cleanup();
 ['',
diff --git a/test/parallel/test-http-unix-socket-keep-alive.js b/test/parallel/test-http-unix-socket-keep-alive.js
@@ -27,6 +27,7 @@ function asyncLoop(fn, times, cb) {
 }
 });
 }
+
 function makeKeepAliveRequest(cb) {
 http.get({
 socketPath: common.PIPE,
diff --git a/test/parallel/test-repl-options.js b/test/parallel/test-repl-options.js
@@ -62,6 +62,7 @@ assert.strictEqual(r1.useColors, r1.rli.terminal);
 
 // 2
 function writer() {}
+
 function evaler() {}
 const r2 = repl.start({
 input: stream,
diff --git a/test/parallel/test-stream-transform-flush-data.js b/test/parallel/test-stream-transform-flush-data.js
@@ -12,6 +12,7 @@ const expected = 'asdf';
 function _transform(d, e, n) {
 n();
 }
+
 function _flush(n) {
 n(null, expected);
 }
diff --git a/test/parallel/test-tls-fast-writing.js b/test/parallel/test-tls-fast-writing.js
@@ -68,6 +68,7 @@ server.listen(0, function() {
 process.exit(0);
 write();
 }
+
 function write() {
 // This needs to return false eventually
 while (false !== conn.write(chunk));
diff --git a/test/parallel/test-util-promisify.js b/test/parallel/test-util-promisify.js
@@ -26,6 +26,7 @@ const stat = promisify(fs.stat);
 
 {
 function fn() {}
+
 function promisifedFn() {}
 fn[promisify.custom] = promisifedFn;
 assert.strictEqual(promisify(fn), promisifedFn);
diff --git a/test/pummel/test-fs-watch-file.js b/test/pummel/test-fs-watch-file.js
@@ -89,6 +89,7 @@ assert.throws(
 fs.unwatchFile(filepathTwo, a);
 ++watchSeenTwo;
 }
+
 function b() {
 fs.unwatchFile(filepathTwo, b);
 ++watchSeenTwo;
diff --git a/test/sequential/test-inspector-port-cluster.js b/test/sequential/test-inspector-port-cluster.js
@@ -205,6 +205,7 @@ function testRunnerMain() {
 });
 });
 }
+
 function masterProcessMain() {
 const workers = JSON.parse(process.env.workers);
 const clusterSettings = JSON.parse(process.env.clusterSettings) || {};

-Original file line number
+Diff line change
 if(j===n)
 bench.end(n);
+}
++
 functioncb2(arg1,arg2){
 j++;
 if(j===n)
 bench.end(n);
+}
++
 functioncb3(arg1,arg2,arg3){
 j++;
 if(j===n)
 bench.end(n);
+}
++
 functioncb4(arg1,arg2,arg3,arg4){
 j++;
 if(j===n)
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@ function main({ n }) {`
`21`	`21`	`setImmediate(cb1,n);`
`22`	`22`	`}`
`23`	`23`	`}`
	`24`	`+`
`24`	`25`	`functioncb2(n,arg2){`
`25`	`26`	`if(--n){`
`26`	`27`	`if(n%3===0)`
`@@ -31,6 +32,7 @@ function main({ n }) {`
`31`	`32`	`setImmediate(cb1,n);`
`32`	`33`	`}`
`33`	`34`	`}`
	`35`	`+`
`34`	`36`	`functioncb1(n){`
`35`	`37`	`if(--n){`
`36`	`38`	`if(n%3===0)`
Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,11 @@ function main({ n }) {`
`19`	`19`	`functioncb(){`
`20`	`20`	`process.nextTick(counter);`
`21`	`21`	`}`
	`22`	`+`
`22`	`23`	`functioncb2(){`
`23`	`24`	`process.nextTick(counter);`
`24`	`25`	`}`
	`26`	`+`
`25`	`27`	`functioncounter(){`
`26`	`28`	`count++;`
`27`	`29`	`if(count===n)`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ function main({ n }) {`
`20`	`20`	`if(count===n)`
`21`	`21`	`bench.end(n);`
`22`	`22`	`}`
	`23`	`+`
`23`	`24`	`functioncb2(){`
`24`	`25`	`count++;`
`25`	`26`	`if(count===n)`
Original file line number	Diff line number	Diff line change
`@@ -1256,9 +1256,11 @@ a string as the second argument gets considered:`
`1256`	`1256`	`functionthrowingFirst() {`
`1257`	`1257`	`thrownewError('First');`
`1258`	`1258`	`}`
	`1259`	`+`
`1259`	`1260`	`functionthrowingSecond() {`
`1260`	`1261`	`thrownewError('Second');`
`1261`	`1262`	`}`
	`1263`	`+`
`1262`	`1264`	`functionnotThrowing() {}`
`1263`	`1265`
`1264`	`1266`	`// The second argument is a string and the input function threw an Error.`
-Original file line number
+Diff line change
 !state.finished&&
 !state.writing);
+}
++
 functioncallFinal(stream,state){
 stream._final((err)=>{
 state.pendingcb--;
 finishMaybe(stream,state);
 });
+}
++
 functionprefinish(stream,state){
 if(!state.prefinished&&!state.finalCalled){
 if(typeofstream._final==='function'&&!state.destroyed){