src: remove 2nd undefined argument in node_file.cc

In the document for fs, there are several functions that state "No
arguments other than a possible exception are given to the completion
callback." (ex> fs.access, fs.chmod, fs.close, ..)
But, the functions are invoking the callback with two parameters (err,
undefined)
It causes problems in using several API like
[async.waterfall](https://caolan.github.io/async/docs.html#waterfall).
PR-URL: #20629Fixes: #20335
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: dankang

src/node_file.cc

@@ -421,7 +421,9 @@ void FSReqWrap::Resolve(Local<Value> value) {
 Null(env()->isolate()),
  value
  };
-MakeCallback(env()->oncomplete_string(), arraysize(argv), argv);
+MakeCallback(env()->oncomplete_string(),
+ value->IsUndefined() ? 1 : arraysize(argv),
+ argv);
 }
 
 voidFSReqWrap::SetReturnValue(const FunctionCallbackInfo<Value>& args) {

test/parallel/test-fs-access.js

@@ -64,15 +64,21 @@ assert.strictEqual(typeof fs.X_OK, 'number');
 
 constthrowNextTick=(e)=>{process.nextTick(()=>{throwe;});};
 
-fs.access(__filename,common.mustCall(assert.ifError));
+fs.access(__filename,common.mustCall(function(...args){
+assert.deepStrictEqual(args,[null]);
+}));
 fs.promises.access(__filename)
 .then(common.mustCall())
 .catch(throwNextTick);
-fs.access(__filename,fs.R_OK,common.mustCall(assert.ifError));
+fs.access(__filename,fs.R_OK,common.mustCall(function(...args){
+assert.deepStrictEqual(args,[null]);
+}));
 fs.promises.access(__filename,fs.R_OK)
 .then(common.mustCall())
 .catch(throwNextTick);
-fs.access(readOnlyFile,fs.F_OK|fs.R_OK,common.mustCall(assert.ifError));
+fs.access(readOnlyFile,fs.F_OK|fs.R_OK,common.mustCall(function(...args){
+assert.deepStrictEqual(args,[null]);
+}));
 fs.promises.access(readOnlyFile,fs.F_OK|fs.R_OK)
 .then(common.mustCall())
 .catch(throwNextTick);

test/parallel/test-fs-close.js

@@ -0,0 +1,12 @@
+'use strict';
+
+constcommon=require('../common');
+
+constassert=require('assert');
+constfs=require('fs');
+
+constfd=fs.openSync(__filename,'r');
+
+fs.close(fd,common.mustCall(function(...args){
+assert.deepStrictEqual(args,[null]);
+}));