module: move test reporter loading

Move the logic for handling --test-reporter out of the
general module loader and into the test_runner subsystem.
PR-URL: #45923
Backport-PR-URL: #46839
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: GeoffreyBooth

doc/api/test.md

@@ -470,7 +470,7 @@ The following built-reporters are supported:
  The `spec` reporter outputs the test results in a human-readable format.
 
 *`dot`
- The `dot` reporter outputs the test results in a comact format,
+ The `dot` reporter outputs the test results in a compact format,
  where each passing test is represented by a `.`,
  and each failing test is represented by a `X`.
 
@@ -591,6 +591,9 @@ module.exports = async function * customReporter(source) {
 };
 ```
 
+The value provided to `--test-reporter` should be a string like one used in an
+`import()` in JavaScript code.
+
 ### Multiple reporters
 
 The [`--test-reporter`][] flag can be specified multiple times to report test

lib/internal/modules/run_main.js

@@ -2,12 +2,12 @@
 
 const{
  ObjectCreate,
+ StringPrototypeEndsWith,
 }=primordials;
 constCJSLoader=require('internal/modules/cjs/loader');
-const{ Module, toRealPath }=CJSLoader;
+const{ Module, toRealPath, readPackageScope}=CJSLoader;
 const{ getOptionValue }=require('internal/options');
 constpath=require('path');
-const{ shouldUseESMLoader }=require('internal/modules/utils');
 const{
  handleProcessExit,
 }=require('internal/modules/esm/handle_process_exit');
@@ -27,6 +27,27 @@ function resolveMainPath(main) {
 returnmainPath;
 }
 
+functionshouldUseESMLoader(mainPath){
+/**
+ * @type {string[]} userLoaders A list of custom loaders registered by the user
+ * (or an empty list when none have been registered).
+ */
+constuserLoaders=getOptionValue('--experimental-loader');
+if(userLoaders.length>0)
+returntrue;
+constesModuleSpecifierResolution=
+getOptionValue('--experimental-specifier-resolution');
+if(esModuleSpecifierResolution==='node')
+returntrue;
+// Determine the module format of the main
+if(mainPath&&StringPrototypeEndsWith(mainPath,'.mjs'))
+returntrue;
+if(!mainPath||StringPrototypeEndsWith(mainPath,'.cjs'))
+returnfalse;
+constpkg=readPackageScope(mainPath);
+returnpkg&&pkg.data.type==='module';
+}
+
 functionrunMainESM(mainPath){
 const{ loadESM }=require('internal/process/esm_loader');
 const{ pathToFileURL }=require('internal/url');

lib/internal/modules/utils.js

@@ -1,6 +1,7 @@
 'use strict';
 const{
  ArrayPrototypePush,
+ ObjectCreate,
  ObjectGetOwnPropertyDescriptor,
  SafePromiseAllReturnArrayLike,
  RegExp,
@@ -9,9 +10,9 @@ const {
 }=primordials;
 const{ basename }=require('path');
 const{ createWriteStream }=require('fs');
+const{ pathToFileURL }=require('internal/url');
 const{ createDeferredPromise }=require('internal/util');
 const{ getOptionValue }=require('internal/options');
-const{ requireOrImport }=require('internal/modules/utils');
 
 const{
 codes: {
@@ -103,7 +104,17 @@ const kDefaultDestination = 'stdout';
 asyncfunctiongetReportersMap(reporters,destinations){
 returnSafePromiseAllReturnArrayLike(reporters,async(name,i)=>{
 constdestination=kBuiltinDestinations.get(destinations[i])??createWriteStream(destinations[i]);
-letreporter=awaitrequireOrImport(kBuiltinReporters.get(name)??name);
+
+// Load the test reporter passed to --test-reporter
+constreporterSpecifier=kBuiltinReporters.get(name)??name;
+letparentURL;
+try{
+parentURL=pathToFileURL(process.cwd()+'/').href;
+}catch{
+parentURL='file:///';
+}
+const{ esmLoader }=require('internal/process/esm_loader');
+letreporter=awaitesmLoader.import(reporterSpecifier,parentURL,ObjectCreate(null));
 
 if(reporter?.default){
 reporter=reporter.default;

lib/internal/test_runner/utils.js

@@ -75,7 +75,6 @@ const expectedModules = new Set([
 'NativeModule internal/mime',
 'NativeModule internal/modules/cjs/helpers',
 'NativeModule internal/modules/cjs/loader',
-'NativeModule internal/modules/utils',
 'NativeModule internal/modules/esm/assert',
 'NativeModule internal/modules/esm/create_dynamic_module',
 'NativeModule internal/modules/esm/fetch_module',

test/fixtures/test-runner/node_modules/reporter-cjs/index.js

@@ -86,10 +86,32 @@ describe('node:test reporters', { concurrency: true }, () => {
 it(`should support a '${ext}' file as a custom reporter`,async()=>{
 constfilename=`custom.${ext}`;
 constchild=spawnSync(process.execPath,
-['--test','--test-reporter',fixtures.path('test-runner/custom_reporters/',filename),
+['--test','--test-reporter',fixtures.fileURL('test-runner/custom_reporters/',filename),
 testFile]);
 assert.strictEqual(child.stderr.toString(),'');
 assert.strictEqual(child.stdout.toString(),`${filename} {"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}`);
 });
 });
+
+it('should support a custom reporter from node_modules',async()=>{
+constchild=spawnSync(process.execPath,
+['--test','--test-reporter','reporter-cjs','reporters.js'],
+{cwd: fixtures.path('test-runner')});
+assert.strictEqual(child.stderr.toString(),'');
+assert.match(
+child.stdout.toString(),
+/^package:reporter-cjs{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\d+}$/,
+);
+});
+
+it('should support a custom ESM reporter from node_modules',async()=>{
+constchild=spawnSync(process.execPath,
+['--test','--test-reporter','reporter-esm','reporters.js'],
+{cwd: fixtures.path('test-runner')});
+assert.strictEqual(child.stderr.toString(),'');
+assert.match(
+child.stdout.toString(),
+/^package:reporter-esm{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":\d+}$/,
+);
+});
 });