tls: do not refer to secureOptions as flags

sam-github · Italo A. Casas · commit 41e1e6eb35a7 · 2016-12-17T13:53:30.000-05:00
Its confusing to have multiple names for the same thing, use secureOptions consistently. PR-URL: #9800 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/lib/_tls_common.js b/lib/_tls_common.js
@@ -12,9 +12,9 @@ var crypto = null;
 const binding = process.binding('crypto');
 const NativeSecureContext = binding.SecureContext;
 
-function SecureContext(secureProtocol, flags, context) {
+function SecureContext(secureProtocol, secureOptions, context) {
 if (!(this instanceof SecureContext)) {
- return new SecureContext(secureProtocol, flags, context);
+ return new SecureContext(secureProtocol, secureOptions, context);
 }
 
 if (context) {
@@ -29,7 +29,7 @@ function SecureContext(secureProtocol, flags, context) {
 }
 }
 
- if (flags) this.context.setOptions(flags);
+ if (secureOptions) this.context.setOptions(secureOptions);
 }
 
 exports.SecureContext = SecureContext;

Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,9 @@ var crypto = null;`
`12`	`12`	`constbinding=process.binding('crypto');`
`13`	`13`	`constNativeSecureContext=binding.SecureContext;`
`14`	`14`
`15`		`-functionSecureContext(secureProtocol,flags,context){`
	`15`	`+functionSecureContext(secureProtocol,secureOptions,context){`
`16`	`16`	`if(!(thisinstanceofSecureContext)){`
`17`		`-returnnewSecureContext(secureProtocol,flags,context);`
	`17`	`+returnnewSecureContext(secureProtocol,secureOptions,context);`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`if(context){`
`@@ -29,7 +29,7 @@ function SecureContext(secureProtocol, flags, context) {`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`-if(flags)this.context.setOptions(flags);`
	`32`	`+if(secureOptions)this.context.setOptions(secureOptions);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`exports.SecureContext=SecureContext;`