test: stricten readline keypress failure test condition

BridgeAR · MylesBorins · commit 424408005fea · 2020-01-16T01:39:14.000-05:00
This verifies that the thrown error is the expected one. That was not tested before. PR-URL: #31300 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js
@@ -561,15 +561,20 @@ function isWarned(emitter) {
 { input: fi, output: fi, terminal: true }
 );
 const keys = [];
+ const err = new Error('bad thing happened');
 fi.on('keypress', function(key) {
 keys.push(key);
 if (key === 'X') {
- throw new Error('bad thing happened');
+ throw err;
 }
 });
- try {
- fi.emit('data', 'fooX');
- } catch { }
+ assert.throws(
+ () => fi.emit('data', 'fooX'),
+ (e) => {
+ assert.strictEqual(e, err);
+ return true;
+ }
+ );
 fi.emit('data', 'bar');
 assert.strictEqual(keys.join(''), 'fooXbar');
 rli.close();

-Original file line number
+Diff line change
 {input: fi,output: fi,terminal: true}
 );
 constkeys=[];
 +consterr=newError('bad thing happened');
 fi.on('keypress',function(key){
 keys.push(key);
 if(key==='X'){
 -thrownewError('bad thing happened');
 +throwerr;
+}
 });
 -try{
 -fi.emit('data','fooX');
 -}catch{}
 +assert.throws(
 +()=>fi.emit('data','fooX'),
 +(e)=>{
 +assert.strictEqual(e,err);
 +returntrue;
 +}
 +);
 fi.emit('data','bar');
 assert.strictEqual(keys.join(''),'fooXbar');
 rli.close();