lib: use spread operator on cluster

himself65 · MylesBorins · commit 435341a94f30 · 2020-03-24T02:55:02.000-04:00
PR-URL: #32125 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js
@@ -66,7 +66,7 @@ cluster.setupMaster = function(options) {
 // process has its own memory mappings.)
 if (settings.execArgv.some((s) => s.startsWith('--prof')) &&
 !settings.execArgv.some((s) => s.startsWith('--logfile='))) {
- settings.execArgv = settings.execArgv.concat(['--logfile=v8-%p.log']);
+ settings.execArgv = [...settings.execArgv, '--logfile=v8-%p.log'];
 }
 
 cluster.settings = settings;
@@ -103,7 +103,7 @@ function setupSettingsNT(settings) {
 
 function createWorkerProcess(id, env) {
 const workerEnv = { ...process.env, ...env, NODE_UNIQUE_ID: `${id}` };
- const execArgv = cluster.settings.execArgv.slice();
+ const execArgv = [...cluster.settings.execArgv];
 const debugArgRegex = /--inspect(?:-brk|-port)?|--debug-port/;
 const nodeOptions = process.env.NODE_OPTIONS ?
 process.env.NODE_OPTIONS : '';

-Original file line number
+Diff line change
 // process has its own memory mappings.)
 if(settings.execArgv.some((s)=>s.startsWith('--prof'))&&
 !settings.execArgv.some((s)=>s.startsWith('--logfile='))){
 -settings.execArgv=settings.execArgv.concat(['--logfile=v8-%p.log']);
 +settings.execArgv=[...settings.execArgv,'--logfile=v8-%p.log'];
+}
 cluster.settings=settings;
 functioncreateWorkerProcess(id,env){
 constworkerEnv={ ...process.env, ...env,NODE_UNIQUE_ID: `${id}`};
 -constexecArgv=cluster.settings.execArgv.slice();
 +constexecArgv=[...cluster.settings.execArgv];
 constdebugArgRegex=/--inspect(?:-brk|-port)?|--debug-port/;
 constnodeOptions=process.env.NODE_OPTIONS ?
 process.env.NODE_OPTIONS : '';