assert,util: fix commutativity edge case

BridgeAR · danielleadams · commit 44514600b242 · 2021-03-16T12:31:40.000-04:00
Verify that both objects property keys are enumerable. Fixes: #37710 PR-URL: #37711 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -282,7 +282,7 @@ function keyCheck(val1, val2, strict, memos, iterationType, aKeys) {
 // Cheap key test
 let i = 0;
 for (; i < aKeys.length; i++) {
- if (!ObjectPrototypeHasOwnProperty(val2, aKeys[i])) {
+ if (!ObjectPrototypePropertyIsEnumerable(val2, aKeys[i])) {
 return false;
 }
 }
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -1194,3 +1194,13 @@ assert.throws(
 Object.setPrototypeOf(b, null);
 assertNotDeepOrStrict(a, b, assert.AssertionError);
 }
+
+{
+ // Verify commutativity
+ // Regression test for https://github.com/nodejs/node/issues/37710
+ const a = { x: 1 };
+ const b = { y: 1 };
+ Object.defineProperty(b, 'x', { value: 1 });
+
+ assertNotDeepOrStrict(a, b);
+}

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ function keyCheck(val1, val2, strict, memos, iterationType, aKeys) {`
`282`	`282`	`// Cheap key test`
`283`	`283`	`leti=0;`
`284`	`284`	`for(;i<aKeys.length;i++){`
`285`		`-if(!ObjectPrototypeHasOwnProperty(val2,aKeys[i])){`
	`285`	`+if(!ObjectPrototypePropertyIsEnumerable(val2,aKeys[i])){`
`286`	`286`	`returnfalse;`
`287`	`287`	`}`
`288`	`288`	`}`
-Original file line number
+Diff line change
 Object.setPrototypeOf(b,null);
 assertNotDeepOrStrict(a,b,assert.AssertionError);
+}
++
 +{
 +// Verify commutativity
 +// Regression test for https://github.com/nodejs/node/issues/37710
 +consta={x: 1};
 +constb={y: 1};
 +Object.defineProperty(b,'x',{value: 1});
++
 +assertNotDeepOrStrict(a,b);
 +}