test: add regex in test_cyclic_link_protection

PR-URL: #11622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: clarenced

test/parallel/test-fs-realpath.js

@@ -191,21 +191,25 @@ function test_cyclic_link_protection(callback) {
 common.skip('symlink test (no privs)');
 returnrunNextTest();
 }
-constentry=common.tmpDir+'/cycles/realpath-3a';
+constentry=path.join(common.tmpDir,'/cycles/realpath-3a');
 [
 [entry,'../cycles/realpath-3b'],
-[common.tmpDir+'/cycles/realpath-3b','../cycles/realpath-3c'],
-[common.tmpDir+'/cycles/realpath-3c','../cycles/realpath-3a']
+[path.join(common.tmpDir,'/cycles/realpath-3b'),'../cycles/realpath-3c'],
+[path.join(common.tmpDir,'/cycles/realpath-3c'),'../cycles/realpath-3a']
 ].forEach(function(t){
 try{fs.unlinkSync(t[0]);}catch(e){}
 fs.symlinkSync(t[1],t[0],'dir');
 unlink.push(t[0]);
 });
-assert.throws(function(){fs.realpathSync(entry);});
-asynctest(fs.realpath,[entry],callback,function(err,result){
-assert.ok(err&&true);
-returntrue;
-});
+assert.throws(()=>{
+fs.realpathSync(entry);
+},common.expectsError({code: 'ELOOP',type: Error}));
+asynctest(
+fs.realpath,[entry],callback,common.mustCall(function(err,result){
+assert.strictEqual(err.path,entry);
+assert.strictEqual(result,undefined);
+returntrue;
+}));
 }
 
 functiontest_cyclic_link_overprotection(callback){