fs: ensure options.flag defaults to 'r' in readFile

When passing {} or { encoding: 'utf8' } as options to readFile, the
flag is not defaulted to 'r' unlike normal fs. This fix makes
fs.promises.readFile() act consistent with fs.readFile().
It also fixes another issue with fs.promises.readfile() where it
returned a Buffer instead of an empty string when encoding is provided.
PR-URL: #20268
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: bdistin

lib/internal/fs/promises.js

@@ -137,7 +137,7 @@ async function readFileHandle(filehandle, options) {
 }
 
 if(size===0)
-returnBuffer.alloc(0);
+returnoptions.encoding ? '' : Buffer.alloc(0);
 
 if(size>kMaxLength)
 thrownewERR_FS_FILE_TOO_LARGE(size);
@@ -459,11 +459,12 @@ async function appendFile(path, data, options) {
 
 asyncfunctionreadFile(path,options){
 options=getOptions(options,{flag: 'r'});
+constflag=options.flag||'r';
 
 if(pathinstanceofFileHandle)
 returnreadFileHandle(path,options);
 
-constfd=awaitopen(path,options.flag,0o666);
+constfd=awaitopen(path,flag,0o666);
 returnreadFileHandle(fd,options).finally(fd.close.bind(fd));
 }
 

test/parallel/test-fs-promises-readfile-empty.js

@@ -0,0 +1,19 @@
+'use strict';
+constcommon=require('../common');
+
+constassert=require('assert');
+const{promises: fs}=require('fs');
+constfixtures=require('../common/fixtures');
+
+constfn=fixtures.path('empty.txt');
+
+common.crashOnUnhandledRejection();
+
+fs.readFile(fn)
+.then(assert.ok);
+
+fs.readFile(fn,'utf8')
+.then(assert.strictEqual.bind(this,''));
+
+fs.readFile(fn,{encoding: 'utf8'})
+.then(assert.strictEqual.bind(this,''));

test/parallel/test-fs-readfile-empty.js

@@ -38,5 +38,9 @@ fs.readFile(fn, 'utf8', function(err, data) {
 assert.strictEqual('',data);
 });
 
+fs.readFile(fn,{encoding: 'utf8'},function(err,data){
+assert.strictEqual('',data);
+});
+
 assert.ok(fs.readFileSync(fn));
 assert.strictEqual('',fs.readFileSync(fn,'utf8'));