Skip to content

Commit 4510ca3

Browse files
shisamatargos
authored andcommitted
test: add tests for fs/promises chown functions
To increase test coverage for fs/promises, add tests for methods chown(), filehandle.chown() and lchown(). PR-URL: #20574 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
1 parent d91742a commit 4510ca3

1 file changed

Lines changed: 32 additions & 0 deletions

File tree

‎test/parallel/test-fs-promises.js‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ const fsPromises = fs.promises;
1010
const{
1111
access,
1212
chmod,
13+
chown,
1314
copyFile,
15+
lchown,
1416
link,
1517
lchmod,
1618
lstat,
@@ -107,6 +109,33 @@ function verifyStatObject(stat) {
107109
awaitchmod(dest,(0o10777));
108110
awaithandle.chmod(0o10777);
109111

112+
if(!common.isWindows){
113+
awaitchown(dest,process.getuid(),process.getgid());
114+
awaithandle.chown(process.getuid(),process.getgid());
115+
}
116+
117+
assert.rejects(
118+
async()=>{
119+
awaitchown(dest,1,-1);
120+
},
121+
{
122+
code: 'ERR_OUT_OF_RANGE',
123+
name: 'RangeError [ERR_OUT_OF_RANGE]',
124+
message: 'The value of "gid" is out of range. '+
125+
'It must be >= 0 && < 4294967296. Received -1'
126+
});
127+
128+
assert.rejects(
129+
async()=>{
130+
awaithandle.chown(1,-1);
131+
},
132+
{
133+
code: 'ERR_OUT_OF_RANGE',
134+
name: 'RangeError [ERR_OUT_OF_RANGE]',
135+
message: 'The value of "gid" is out of range. '+
136+
'It must be >= 0 && < 4294967296. Received -1'
137+
});
138+
110139
awaitutimes(dest,newDate(),newDate());
111140

112141
try{
@@ -130,6 +159,9 @@ function verifyStatObject(stat) {
130159
if(common.canCreateSymLink()){
131160
constnewLink=path.resolve(tmpDir,'baz3.js');
132161
awaitsymlink(newPath,newLink);
162+
if(!common.isWindows){
163+
awaitlchown(newLink,process.getuid(),process.getgid());
164+
}
133165
stats=awaitlstat(newLink);
134166
verifyStatObject(stats);
135167

0 commit comments

Comments
 (0)