lib: speed up MessageEvent creation internally

KhafraDev · targos · commit 452011b71901 · 2024-06-20T14:45:15.000+02:00
PR-URL: #52951 Refs: nodejs/undici#3170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/worker/io.js b/lib/internal/worker/io.js
@@ -85,9 +85,12 @@ const messageTypes = {
 LOAD_SCRIPT: 'loadScript',
 };
 
-let messageEvent;
-function lazyMessageEvent() {
- return messageEvent ??= require('internal/deps/undici/undici').MessageEvent;
+// createFastMessageEvent skips webidl argument validation when the arguments
+// passed are known to be valid.
+let fastCreateMessageEvent;
+function lazyMessageEvent(type, init) {
+ fastCreateMessageEvent ??= require('internal/deps/undici/undici').createFastMessageEvent;
+ return fastCreateMessageEvent(type, init);
 }
 
 // We have to mess with the MessagePort prototype a bit, so that a) we can make
@@ -128,7 +131,7 @@ ObjectDefineProperty(
 }
 const ports = this[kCurrentlyReceivingPorts];
 this[kCurrentlyReceivingPorts] = undefined;
- return new (lazyMessageEvent())(type, { data, ports });
+ return lazyMessageEvent(type, { data, ports });
 },
 configurable: false,
 writable: false,
@@ -321,7 +324,7 @@ function receiveMessageOnPort(port) {
 }
 
 function onMessageEvent(type, data) {
- this.dispatchEvent(new (lazyMessageEvent())(type, { data }));
+ this.dispatchEvent(lazyMessageEvent(type, { data }));
 }
 
 function isBroadcastChannel(value) {

-Original file line number
+Diff line change
 LOAD_SCRIPT: 'loadScript',
 };
 -letmessageEvent;
 -functionlazyMessageEvent(){
 -returnmessageEvent??=require('internal/deps/undici/undici').MessageEvent;
 +// createFastMessageEvent skips webidl argument validation when the arguments
 +// passed are known to be valid.
 +letfastCreateMessageEvent;
 +functionlazyMessageEvent(type,init){
 +fastCreateMessageEvent??=require('internal/deps/undici/undici').createFastMessageEvent;
 +returnfastCreateMessageEvent(type,init);
+}
 // We have to mess with the MessagePort prototype a bit, so that a) we can make
+}
 constports=this[kCurrentlyReceivingPorts];
 this[kCurrentlyReceivingPorts]=undefined;
 -returnnew(lazyMessageEvent())(type,{ data, ports });
 +returnlazyMessageEvent(type,{ data, ports });
 },
 configurable: false,
 writable: false,
+}
 functiononMessageEvent(type,data){
 -this.dispatchEvent(new(lazyMessageEvent())(type,{ data }));
 +this.dispatchEvent(lazyMessageEvent(type,{ data }));
+}
 functionisBroadcastChannel(value){