lib: remove outdated optimizations

starkwang · targos · commit 47d311b3f07f · 2019-04-29T16:57:36.000+02:00
PR-URL: #27380 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js
@@ -93,9 +93,6 @@ function processTicksAndRejections() {
 
 class TickObject {
 constructor(callback, args, triggerAsyncId) {
- // This must be set to null first to avoid function tracking
- // on the hidden class, revisit in V8 versions after 6.2
- this.callback = null;
 this.callback = callback;
 this.args = args;
 
diff --git a/lib/timers.js b/lib/timers.js
@@ -207,9 +207,6 @@ const Immediate = class Immediate {
 constructor(callback, args) {
 this._idleNext = null;
 this._idlePrev = null;
- // This must be set to null first to avoid function tracking
- // on the hidden class, revisit in V8 versions after 6.2
- this._onImmediate = null;
 this._onImmediate = callback;
 this._argv = args;
 this._destroyed = false;

-Original file line number
+Diff line change
 classTickObject{
 constructor(callback,args,triggerAsyncId){
 -// This must be set to null first to avoid function tracking
 -// on the hidden class, revisit in V8 versions after 6.2
 -this.callback=null;
 this.callback=callback;
 this.args=args;
-Original file line number
+Diff line change
 constructor(callback,args){
 this._idleNext=null;
 this._idlePrev=null;
 -// This must be set to null first to avoid function tracking
 -// on the hidden class, revisit in V8 versions after 6.2
 -this._onImmediate=null;
 this._onImmediate=callback;
 this._argv=args;
 this._destroyed=false;