Skip to content

Commit 4885e50

Browse files
richardlauTrott
authored andcommitted
build: make full-icu the default for releases
Release builds specifically set the `--with-intl=` configure option instead of relying on the default. Explicitly set to `full-icu`. Refs: #29522 PR-URL: #29887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 458a38c commit 4885e50

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ NPM ?= ./deps/npm/bin/npm-cli.js
5252

5353
# Flags for packaging.
5454
BUILD_DOWNLOAD_FLAGS ?= --download=all
55-
BUILD_INTL_FLAGS ?= --with-intl=small-icu
55+
BUILD_INTL_FLAGS ?= --with-intl=full-icu
5656
BUILD_RELEASE_FLAGS ?= $(BUILD_DOWNLOAD_FLAGS)$(BUILD_INTL_FLAGS)
5757

5858
# Default to quiet/pretty builds.

‎vcbuild.bat‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ if /i "%1"=="lint-md-build" set lint_md_build=1&goto arg-ok
120120
if /i "%1"=="lint"setlint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok
121121
if /i "%1"=="lint-ci"setlint_cpp=1&set lint_js_ci=1&goto arg-ok
122122
if /i "%1"=="package"setpackage=1&goto arg-ok
123-
if /i "%1"=="msi"setmsi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
123+
if /i "%1"=="msi"setmsi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=full-icu&goto arg-ok
124124
if /i "%1"=="build-release"setbuild_release=1&set sign=1&goto arg-ok
125125
if /i "%1"=="upload"setupload=1&goto arg-ok
126126
if /i "%1"=="small-icu"seti18n_arg=%1&goto arg-ok
@@ -158,7 +158,7 @@ if defined build_release (
158158
setmsi=1
159159
setlicensertf=1
160160
setdownload_arg="--download=all"
161-
seti18n_arg=small-icu
161+
seti18n_arg=full-icu
162162
setprojgen=1
163163
setcctest=1
164164
setltcg=1

0 commit comments

Comments
 (0)