assert: special handle identical error names in instance checks

This makes sure that using `assert.throws()` or `assert.rejects()`
in combination with Error classes log appropriate error messages
in case the expected and received constructor name are identical
but not part of the same prototype chain.
PR-URL: #28263
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: BridgeAR

lib/assert.js

@@ -620,10 +620,14 @@ function expectedException(actual, expected, message, fn) {
 generatedMessage=true;
 message='The error is expected to be an instance of '+
 `"${expected.name}". Received `;
-// TODO: Special handle identical names.
 if(isError(actual)){
-constname=actual.constructor&&actual.constructor.name;
-message+=`"${name||actual.name}"`;
+constname=actual.constructor&&actual.constructor.name||
+actual.name;
+if(expected.name===name){
+message+='an error with identical name but a different prototype.';
+}else{
+message+=`"${name}"`;
+}
 if(actual.message){
 message+=`\n\nError message:\n\n${actual.message}`;
 }

test/parallel/test-assert.js

@@ -25,6 +25,7 @@
 constcommon=require('../common');
 constassert=require('assert');
 const{ inspect }=require('util');
+constvm=require('vm');
 const{ internalBinding }=require('internal/test/binding');
 consta=assert;
 
@@ -1344,3 +1345,17 @@ assert.throws(
 }
 );
 }
+
+assert.throws(
+()=>{
+constscript=newvm.Script('new RangeError("foobar");');
+constcontext=vm.createContext();
+consterr=script.runInContext(context);
+assert.throws(()=>{throwerr;},RangeError);
+},
+{
+message: 'The error is expected to be an instance of "RangeError". '+
+'Received an error with identical name but a different '+
+'prototype.\n\nError message:\n\nfoobar'
+}
+);