assert: loose deep equal should not compare symbol properties

This is the way it's currently documented and that seems appropriate
for loose equal assertions. The change was not intentional.
Fixes: #27652
PR-URL: #27653
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

Author: BridgeAR

lib/internal/util/comparisons.js

@@ -37,7 +37,8 @@ const {
 const{
  getOwnNonIndexProperties,
 propertyFilter: {
-ONLY_ENUMERABLE
+ONLY_ENUMERABLE,
+SKIP_SYMBOLS
 }
 }=internalBinding('util');
 
@@ -163,8 +164,9 @@ function innerDeepEqual(val1, val2, strict, memos) {
 if(val1.length!==val2.length){
 returnfalse;
 }
-constkeys1=getOwnNonIndexProperties(val1,ONLY_ENUMERABLE);
-constkeys2=getOwnNonIndexProperties(val2,ONLY_ENUMERABLE);
+constfilter=strict ? ONLY_ENUMERABLE : ONLY_ENUMERABLE|SKIP_SYMBOLS;
+constkeys1=getOwnNonIndexProperties(val1,filter);
+constkeys2=getOwnNonIndexProperties(val2,filter);
 if(keys1.length!==keys2.length){
 returnfalse;
 }
@@ -198,8 +200,9 @@ function innerDeepEqual(val1, val2, strict, memos) {
 // Buffer.compare returns true, so val1.length === val2.length. If they both
 // only contain numeric keys, we don't need to exam further than checking
 // the symbols.
-constkeys1=getOwnNonIndexProperties(val1,ONLY_ENUMERABLE);
-constkeys2=getOwnNonIndexProperties(val2,ONLY_ENUMERABLE);
+constfilter=strict ? ONLY_ENUMERABLE : ONLY_ENUMERABLE|SKIP_SYMBOLS;
+constkeys1=getOwnNonIndexProperties(val1,filter);
+constkeys2=getOwnNonIndexProperties(val2,filter);
 if(keys1.length!==keys2.length){
 returnfalse;
 }

test/parallel/test-assert-deep.js

@@ -639,7 +639,7 @@ assertDeepAndStrictEqual(-0, -0);
 constb=newUint8Array(4);
 a[symbol1]=true;
 b[symbol1]=false;
-assertNotDeepOrStrict(a,b);
+assertOnlyDeepEqual(a,b);
 b[symbol1]=true;
 assertDeepAndStrictEqual(a,b);
 // The same as TypedArrays is valid for boxed primitives
@@ -649,6 +649,13 @@ assertDeepAndStrictEqual(-0, -0);
 assertOnlyDeepEqual(boxedStringA,boxedStringB);
 boxedStringA[symbol1]=true;
 assertDeepAndStrictEqual(a,b);
+// Loose equal arrays should not compare symbols.
+constarr=[1];
+constarr2=[1];
+arr[symbol1]=true;
+assertOnlyDeepEqual(arr,arr2);
+arr2[symbol1]=false;
+assertOnlyDeepEqual(arr,arr2);
 }
 
 assert.throws(