test: use common.canCreateSymLink() consistently

This commit replaces two ad hoc symlink permission tests with
common.canCreateSymLink().
PR-URL: #20540
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: cjihrig

test/parallel/test-fs-realpath.js

@@ -27,11 +27,10 @@ const tmpdir = require('../common/tmpdir');
 constassert=require('assert');
 constfs=require('fs');
 constpath=require('path');
-constexec=require('child_process').exec;
 letasync_completed=0;
 letasync_expected=0;
 constunlink=[];
-letskipSymlinks=false;
+constskipSymlinks=!common.canCreateSymLink();
 consttmpDir=tmpdir.path;
 
 tmpdir.refresh();
@@ -45,25 +44,9 @@ if (common.isWindows) {
 assert
 .strictEqual(path_left.toLowerCase(),path_right.toLowerCase(),message);
 };
-
-// On Windows, creating symlinks requires admin privileges.
-// We'll only try to run symlink test if we have enough privileges.
-try{
-exec('whoami /priv',function(err,o){
-if(err||!o.includes('SeCreateSymbolicLinkPrivilege')){
-skipSymlinks=true;
-}
-runTest();
-});
-}catch(er){
-// better safe than sorry
-skipSymlinks=true;
-process.nextTick(runTest);
-}
-}else{
-process.nextTick(runTest);
 }
 
+process.nextTick(runTest);
 
 functiontmp(p){
 returnpath.join(tmpDir,p);

test/parallel/test-trace-events-fs-sync.js

@@ -9,21 +9,8 @@ const traceFile = 'node_trace.1.log';
 
 letgid=1;
 letuid=1;
-letskipSymlinks=false;
 
-// On Windows, creating symlinks requires admin privileges.
-// We'll check if we have enough privileges.
-if(common.isWindows){
-try{
-consto=cp.execSync('whoami /priv');
-if(!o.includes('SeCreateSymbolicLinkPrivilege')){
-skipSymlinks=true;
-}
-}catch(er){
-// better safe than sorry
-skipSymlinks=true;
-}
-}else{
+if(!common.isWindows){
 gid=process.getgid();
 uid=process.getuid();
 }
@@ -111,7 +98,7 @@ tests['fs.sync.write'] = 'fs.writeFileSync("fs.txt", "123", "utf8");' +
 
 // On windows, we need permissions to test symlink and readlink.
 // We'll only try to run these tests if we have enough privileges.
-if(!skipSymlinks){
+if(common.canCreateSymLink()){
 tests['fs.sync.symlink']='fs.writeFileSync("fs.txt", "123", "utf8");'+
 'fs.symlinkSync("fs.txt", "linkx");'+
 'fs.unlinkSync("linkx");'+